Skip to content
OverviewSolutions
22
Comments
30
Amulya Prakash
@amulyalovescoding

All comments

  • Amulya Prakash•800
    @amulyalovescodingPosted about 2 years ago

    Hello @yewcm123, Congratulations on completing this challenge! I really liked the result of your project, but I have some suggestion that I like to share: -

    1> <div><span>2</span></div> Selected rating no is not visible. Change text color during selection.

    2> Add alt description or alt="" aria-hidden="true".

    You can go through my solution if you like. Solution Link

    ✌️ I hope this helps you. Happy Coding

    1
  • Amulya Prakash•800
    @amulyalovescodingPosted about 2 years ago

    Hello @samlors, Congratulations on completing this challenge! I really liked the result of your project, but I have some suggestion that I like to share: -

    1> Increase h1 font-size & decrease <p> line height.

    2> Add <p> margin-top or h1 margin-bottom as both are too close with each other.

    You can go through my solution if you like. Solution Link

    ✌️ I hope this helps you. Happy Coding.

    0
  • Maxwell Takyi•250
    @damagermaxSubmitted about 2 years ago

    Though I was able to achieve the desired result, I'm not sure if I am following the best practices. Any help, criticism, or feedback is welcome, I am here to learn!

    Responsive News Homepage - Vanilla CSS

    1
    Amulya Prakash•800
    @amulyalovescodingPosted about 2 years ago

    Hello Maxwell Takyi, Congratulations on completing this challenge! I really liked the result of your project, but i have some suggestion that i like to share:-

    1> Increase <p> font-size in Max-width: 535px .

    2> Nav should be hidden in mobile resolution but it still display in right side.

    You can go through my solution if you like. Solution Link

    ✌️ I hope this helps you. Happy Coding.

    Marked as helpful
    0
  • Amulya Prakash•800
    @amulyalovescodingPosted about 2 years ago

    Hello Sahiru, Congratulations on completing this challenge!

    I really liked the result of your project, specially it returns back to start page after showing rating.

    My suggestion - add little more padding to main-container on bottom .

    ✌️ I hope this helps you. Happy Coding.

    1
  • Amulya Prakash•800
    @amulyalovescodingPosted about 2 years ago

    Hello @Mennatallah-Hisham, Congratulations on completing this challenge!

    I really liked the result of your project, but it seems that on clicking the cube, quote doesn't change.

    You can go through my solution if you like. [Solution] (https://www.frontendmentor.io/solutions/advice-generator-app-using-bootstrap-and-js-SVBqjXVSYG)

    ✌️ I hope this helps you. Happy Coding.

    Marked as helpful
    0
  • Amulya Prakash•800
    @amulyalovescodingPosted about 2 years ago

    Great job. Keep it up

    0
  • Amulya Prakash•800
    @amulyalovescodingPosted about 2 years ago

    Hello Adam Wilder, Congratulations on completing this challenge! I really liked the result of your project, but I have some tips that I like to share:

    1- Every page should have one main landmark <main>. So replace the div that wraps the whole content with <main> to improve the accessibility. click here

    2- All page content should be contained by landmarks, you can understand better by clicking here: click here

    ✌️ I hope this helps you. Happy Coding.

    Marked as helpful
    1
  • Amulya Prakash•800
    @amulyalovescodingPosted about 2 years ago

    Hello @yurideoliveira2712, Congratulations on completing this challenge! I really liked the result of your project, but I have some tips that I like to share:

    1- Every page should have one main landmark <main>. So replace the div that wraps the whole content with <main> to improve the accessibility. click here

    2- All page content should be contained by landmarks, you can understand better by clicking here: click here

    Happy Coading

    Marked as helpful
    0
  • Amulya Prakash•800
    @amulyalovescodingPosted about 2 years ago

    Hello @dedsec-ninja420, Congratulations on completing this challenge!

    I really liked the result of your project, specially you implemented Bootstrap as well.

    Happy Coading

    0
  • Anubhav Ray•140
    @Anubhav-RaySubmitted about 2 years ago
    1. How do I make this website according to mobile design?
    2. How do I pull up the strike through price so it is inline with the bold price as given in the design for desktop

    Product Preview Card

    3
    Amulya Prakash•800
    @amulyalovescodingPosted about 2 years ago

    Hello Anubhav Ray, Congratulations on completing this challenge! I really liked the result of your project, but I have some tips that I like to share:

    1- Every page should have one main landmark <main>. So replace the div that wraps the whole content with <main> to improve the accessibility. click here

    2- All page content should be contained by landmarks, you can understand better by clicking here: click here

    Q. How do I make this website according to mobile design?

    =>Use the media query property to layout according to mobile design and modify the max width that you want the styles to take effect. It will allow you to modify component's property accordingly.

    example-

    @media only screen and (max-width: 600px) {
  body {
    background-color: lightblue;
  }
}

    Q. How do I pull up the strike through price so it is inline with the bold price as given in the design for desktop

    =>

    <div class="textalign">
    <span class="span1">$149.99 </span>
  <span class="span2"><s>$169.99</s></span>
  </div>

    css-

    .textalign {
    text-align: left;
    display: flex;
    align-items: center;
}

    You can go through my solution if you like click here

    ✌️ I hope this helps you. Happy Coding.

    Marked as helpful
    1
  • Amulya Prakash•800
    @amulyalovescodingPosted about 2 years ago

    HelloDhemol, Congratulations on completing this challenge! I really liked the result of your project, but I have some tips that I like to share:

    1- Every page should have one main landmark <main>. So replace the div that wraps the whole content with <main> to improve the accessibility. click here

    2- All page content should be contained by landmarks, you can understand better by clicking here: click here

    3- A meta element with an http-equiv attribute whose value is X-UA-Compatible must have a content attribute with the value IE=edge. Context:

    UTF-8> <meta http-equiv=X-UA-Compatible content=IE=7> `

    You can go through my solution if you like click here

    ✌️ I hope this helps you. Happy Coding.

    Marked as helpful
    1
  • mehmet Alptekin Isiklar•80
    @aisiklarSubmitted about 2 years ago

    Hi, I found centering the design and defining the width the same as the width of the screen a little bit challenging.. I will appreciate a lot if you can review my solution and return me with

    • errors / incomplete parts
    • inefficiencies and what could be better written (if the solution is correct)

    Thanks.

    responsive web site with vanilla JS

    2
    Amulya Prakash•800
    @amulyalovescodingPosted about 2 years ago

    Hello mehmet Alptekin Isiklar, Congratulations on completing this challenge! I really liked the result of your project, but I have some tips that I like to share:

    1- Every page should have one main landmark <main>. So replace the div that wraps the whole content with <main> to improve the accessibility. click here

    2- All page content should be contained by landmarks, you can understand better by clicking here: click here

    3- Bad value `` for attribute src on element script: Must be non-empty. Context: </div> </scri

    4- Consider adding a lang attribute to the html start tag to declare the language of this document. Context:

    TYPE html><html><head>

    You can go through my solution if you like click here

    ✌️ I hope this helps you. Happy Coding.

    Marked as helpful
    1