Submitted almost 2 years ago

Using Intermidiate HTML and CSS

Musharaf Aahel A• 20

@musharafaahel

Preview site(opens in new window)View code(opens in new window)

This is a solution for...

Product preview card component

HTML
CSS

1newbie

View challenge

Design comparison

SolutionDesign

Solution retrospective

I have developed this site with only intermidiate knowledge of HTML and CSS. So give me feedback for this site.

Community feedback

Paul Valladares• 290

@dreyfus92

Posted almost 2 years ago

Hello @musharafaahel good job on completing this project 🚀 ! I was reading your code and I have a few suggestions:

Using Backslash () used as path segment delimiter is not a good practice, try to stick to (/)
If use icons as images try to give them an alt attribute describing what the icon is e.g. src="images/icon-cart.svg" alt="icon-cart"

Marked as helpful

Musharaf Aahel A• 20

@musharafaahel

Posted almost 2 years ago

Hi @dreyfus92 , definitely sure I will learn these topics, could you please share any resource to learn about this because I am new to this just 5 days experience in HTML and CSS, So don't know where to learn these things.

It will be helpful if you provide resources to learn about above mentioned topics.

Thank you, Musharaf Aahel A

Paul Valladares• 290

@dreyfus92

Posted almost 2 years ago

@musharafaahel you can review the report that frontendmentor gives you. Here you have the link https://www.frontendmentor.io/solutions/using-intermidiate-html-and-css-aVB8wh9NpI/report

Amulya Prakash• 800

@amulyalovescoding

Posted almost 2 years ago

Hello @musharafaahel, Congratulations on completing this challenge! I really liked the result of your project, but I have some tips that I like to share:

1- Every page should have one main landmark <main>. So replace the div that wraps the whole content with <main> to improve the accessibility. click here

2- All page content should be contained by landmarks, you can understand better by clicking here: click here

Also its not mobile responsive. You can go through my solution if you like click here

✌️ I hope this helps you. Happy Coding.

Marked as helpful

Musharaf Aahel A• 20

@musharafaahel

Posted almost 2 years ago

Hi @amulyalovescoding, definitely sure I will learn these topics and improve my existing skills and try to implement in my project.

Thanks a lot fot guiding me towards a successfull web developer.

Thank you, Musharaf Aahel A

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord