Interactive raiting component

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted about 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • Change width to max-width in your component’s container to make it responsive. You will also want to delete the height as it is unnecessary.

  • The “icons/images” in this component serve no other purpose then to be decorative; They add no value. There Alt Tag should be left blank and have an aria-hidden=“true” to hide them from assistive technology.

  More Info:📚

  https://www.w3.org/WAI/tutorials/images/

  • Wrap your ratings and submit button in a form element you will also wrap the rating in a fieldset.

  More Info:📚

  MDN <fieldset>: The Field Set element

  • Currently, users can submit without selecting a rating. To fix this, you can do one of the following:

  1. Make the “5” rating the default rating.
  2. Create an error message, telling users they need make a section.
  3. Disable the button until a selection is made.

  • The "Thank You" screen is incorrect. The ratings and submit button should hidden.

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding! 🍂🦃

  0
• 

  Amulya Prakash•800

  @amulyalovescodingPosted about 2 years ago

  Hello @samlors, Congratulations on completing this challenge! I really liked the result of your project, but I have some suggestion that I like to share: -

  1> Increase h1 font-size & decrease <p> line height.

  2> Add <p> margin-top or h1 margin-bottom as both are too close with each other.

  You can go through my solution if you like. Solution Link

  ✌️ I hope this helps you. Happy Coding.

  0