CSS and HTLM

Community feedback

• 

  Amulya Prakash•800

  @amulyalovescodingPosted over 2 years ago

  Hello @Exileurt, Congratulations on completing this challenge! I really liked the result of your project, but I have some tips that I like to share:

  1- Every page should have one main landmark <main>. So replace the div that wraps the whole content with <main> to improve the accessibility. click here

  2- Images must have alternate text

  Context: <img src="images/icon-cart.svg" id="cart"> click here

  Also its not mobile responsive. You can go through my solution if you like click here

  ✌️ I hope this helps you. Happy Coding.

  Marked as helpful

  1
• 

  Maximiliano Torres•120

  @MaxiTRRPosted over 2 years ago

  Hi @Exileurt! Congratulations for this challenge! I have a tipo for you: try to place this in your body css:

  body {
    display:flex;
  justify-content:center;
  align-items:center;
  flex-direction:column;
  }
  

  This will center the whole card to the center of the screen, so yo dont have to use any margins of any kind to do it.

  Marked as helpful

  0
• 

  Lucas 👾•104,220

  @correlucasPosted over 2 years ago

  👾Hello @Exileurt, Congratulations on completing this challenge!

  Unfortunately your live site is not previewing, due an error with the Github Pages I don’t recommend it since it's too hard to set up.

  If you really want to use Github Pages you can try to follow this guide to use it and fix the settings for your page https://docs.github.com/en/pages/quickstart.

  My suggestion it that you use vercel.com or netlify.com that are really easier platforms for live sets and totally user-friendly, in a matter of 5min your live site is online. All you need to do is to connect the Github account, import the repository and deploy it. Really fast.The easy one is Vercel and is the one I use for my solution.

  Fixing that you've to update the solution with the new link and we'll be able to see your live site and help you.

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  0