Skip to content
OverviewSolutions
32
Comments
618
Abdul
@Samadeen

All comments

  • Abdul•8,540
    @SamadeenPosted 10 months ago

    Hello Nsebo

    Great work on completing this challenge. Cheers!! 🎊🎊

    Some adjustments are needed to place your container in the middle properly.

        display: grid;
     place-content: center;
     min-height: 100vh;

    I hope to see more solutions from you.

    1
  • 👾 Ekaterine Mitagvaria 👾•7,600
    @catherineisonlineSubmitted over 2 years ago

    Hello, Frontend Mentor community! This is my solution to the REST Countries API with a color theme switcher.

    I appreciate all the feedback you left that helped me to improve this project. I fixed the issues I had previously and added new features per your recommendation.

    I have done this project a while ago however if you are here and have any feedback, tips, or ideas to share, I will be more than glad to hear them out!

    Thanks

    REST Countries API with color theme switcher

    13
    Abdul•8,540
    @SamadeenPosted about 2 years ago

    Hello Catherine... You did beautifully well on this project, can you kindly recommend resources to learn React

    0
  • Woodrow Martyr•120
    @wmartyrSubmitted over 2 years ago

    Hi everyone. I spent some time to get the hover effects right. I'm sure there's a better way to do the things better than what I've done here. Feedback is most welcome. Thanks.

    Used HTML, CSS, and Flexbox.

    1
    Abdul•8,540
    @SamadeenPosted over 2 years ago

    Hey Woodrow!! Cheers 🥂 on completing this challenge.. .

    Lets firstly work on your accessibility issues.

    • Document should have on main landmark basically means your html should be structured more semantically and the correct format should be your <header>......</header> followed by your <main>......</main> and lastly your <footer>....</footer> hence you should use <main class="card"> instead of <div class="card">.
    • Your footer should be <footer class="attribution"> instead of <div =attribution>
    • Images must have alternate text - Its hard for screen readers to pick up messages from images without alt text.. Its always advisable to include alt text to aid screen reader

    This should fix most of your accessibility issues.

    • For your design here is a tip to center your container both vertically and horizontally display: grid; place-content: center; min-height: 100vh;

    . Regardless you did amazing... hope you find this helpful... Happy coding!!!

    Marked as helpful
    0
  • Abdul•8,540
    @SamadeenPosted over 2 years ago

    Hey Omo Iya mi!! Cheers 🥂 on completing this challenge.. .

    Lets firstly work on your accessibility issues.

    • Document should have on main landmark basically means your html should be structured more semantically and the correct format should be your <header>......</header> followed by your <main>......</main> and lastly your <footer>....</footer> hence you should use <main class="content"> instead of <div class="content">.

    • Page should contain a level-one heading basically means your html should have a h1 it aid navigation hence <h5 id="top">Improve your front-end skills by building projects</h5> should be <h1 id="top">Improve your front-end skills by building projects</h1> and you should also go down orderly when you are using the headings h1 down to h2 down to h3 and so on.

    This should fix most of your accessibility issues.

    . Regardless you did amazing... hope you find this helpful... Happy coding!!!

    Marked as helpful
    0
  • Abdul•8,540
    @SamadeenPosted over 2 years ago

    Hey!! Cheers 🥂 on completing this challenge.. .

    Lets firstly work on your accessibility issues.

    • Document should have on main landmark basically means your html should be structured more semantically and the correct format should be your <header>......</header> followed by your <main>......</main> and lastly your <footer>....</footer> hence you should use <main class="card"> instead of <section class="card">.

    • Your footer should be <footer class="attribution"> instead of <div =attribution>

    • Page should contain a level-one heading basically means your html should have a h1 it aid navigation hence <h1 class="big-text"> Equilibrium #3429 </p> should be <p class="big-text"> Equilibrium #3429 </h1> and you should also go down orderly when you are using the headings h1 down to h2 down to h3 and so on.

    This should fix most of your accessibility issues.

    . Regardless you did amazing... hope you find this helpful... Happy coding!!!

    Marked as helpful
    0
  • Abdul•8,540
    @SamadeenPosted over 2 years ago

    Hey!! Cheers 🥂 on completing this challenge.. .

    Lets firstly work on your accessibility issues.

    • Document should have on main landmark basically means your html should be structured more semantically and the correct format should be your <header>......</header> followed by your <main>......</main> and lastly your <footer>....</footer> hence you should use <main class="card"> instead of <div class="card">.

    • Your footer should be <footer class="attribution"> instead of <div =attribution>

    • Page should contain a level-one heading basically means your html should have a h1 it aid navigation hence <h2 class="card__heading">Equilibrium #3429</h2> should be <h21class="card__heading">Equilibrium #3429</h1> and you should also go down orderly when you are using the headings h1 down to h2 down to h3 and so on.

    • Images must have alternate text - Its hard for screen readers to pick up messages from images without alt text.. Its always advisable to include alt text to aid screen reader

    This should fix most of your accessibility issues.

    . Regardless you did amazing... hope you find this helpful... Happy coding!!!

    Marked as helpful
    1
  • Abdul•8,540
    @SamadeenPosted over 2 years ago

    Hey!! Cheers 🥂 on completing this challenge.. .

    • I noticed your container is not aligned vertically and horizontally.. i.e is not at the center of your webpage.. That can be corrected by setting display:flex; align-items:center; justify-content:center;

    . Regardless you did amazing... hope you find this helpful... Happy coding!!!

    1
  • Abdul•8,540
    @SamadeenPosted over 2 years ago

    Hey!! Cheers 🥂 on completing this challenge.. .

    Lets firstly work on your accessibility issues.

    • Document should have on main landmark basically means your html should be structured more semantically and the correct format should be your <header>......</header> followed by your <main>......</main> and lastly your <footer>....</footer> hence you should use <main class="row"> instead of <div class="row">.
    • Your footer should be <footer class="attribution"> instead of <div class="attribution">.
    • Page should contain a level-one heading basically means your html should have a h1 it aid navigation hence <p class="qoute"> "Please click the button below to get an advice." </p> should be <h1 class="qoute"> "Please click the button below to get an advice." </h1> and you should also go down orderly when you are using the headings h1 down to h2 down to h3 and so on.

    This should fix most of your accessibility issues.

    . Regardless you did amazing... hope you find this helpful... Happy coding!!!

    0
  • Chaitali•10
    @chaitalikarmakarSubmitted over 2 years ago

    Hello,

    I am new to front end development and practicing to get better. This is one of the first challenges I took from frontend mentor. Please review and let me know how I can do better.

    Thank you.

    HTML5, CSS, Flexbox

    1
    Abdul•8,540
    @SamadeenPosted over 2 years ago

    Hey!! Cheers 🥂 on completing this challenge.. .

    Lets firstly work on your accessibility issues.

    • Document should have on main landmark basically means your html should be structured more semantically and the correct format should be your <header>......</header> followed by your <main>......</main> and lastly your <footer>....</footer> hence you should use <main class="background-layout"> instead of <div class="background-layout">.
    • Page should contain a level-one heading basically means your html should have a h1 it aid navigation hence <h3>Improve your front-end skills by building projects</h3> should be <h1>Improve your front-end skills by building projects</h1> and you should also go down orderly when you are using the headings h1 down to h2 down to h3 and so on.

    This should fix most of your accessibility issues.

    . Regardless you did amazing... hope you find this helpful... Happy coding!!!

    0
  • Surajit Shaw•10
    @SURAJITSHAWSubmitted over 2 years ago

    Hey everyone I'm very new to these challenges, so open to any kind of suggestions to make my HTML & CSS skills more polished.

    qr code component

    2
    Abdul•8,540
    @SamadeenPosted over 2 years ago

    Hey!! Cheers 🥂 on completing this challenge.. .

    Lets firstly work on your accessibility issues.

    • Document should have on main landmark basically means your html should be structured more semantically and the correct format should be your <header>......</header> followed by your <main>......</main> and lastly your <footer>....</footer> hence you should use <main class="card"> instead of <div class="card">.
    • Page should contain a level-one heading basically means your html should have a h1 it aid navigation hence <h3>Improve your front-end skills by building projects</h3> should be <h1>Improve your front-end skills by building projects</h1> and you should also go down orderly when you are using the headings h1 down to h2 down to h3 and so on.

    This should fix most of your accessibility issues.

    . Regardless you did amazing... hope you find this helpful... Happy coding!!!

    Marked as helpful
    1
  • Abdul•8,540
    @SamadeenPosted over 2 years ago

    Hey!! Cheers 🥂 on completing this challenge.. .

    Lets firstly work on your accessibility issues.

    • Document should have on main landmark basically means your html should be structured more semantically and the correct format should be your <header>......</header> followed by your <main>......</main> and lastly your <footer>....</footer> hence you should use <main class="container"> instead of <div class="container">.

    This should fix most of your accessibility issues.

    . Regardless you did amazing... hope you find this helpful... Happy coding!!!

    Marked as helpful
    0
  • Abdul•8,540
    @SamadeenPosted over 2 years ago

    ** ¡Hey! ** Saludos 🥂 Al completar este desafío ...

    Primero trabajemos en sus problemas de accesibilidad.

    • El documento debe tener en el punto de referencia principal" Básicamente significa que su HTML debe estructurarse de manera más semántica y el formato correcto debe ser su <Header> ... ... ... </main> y, por último, su <footer> .... </footer> , por lo tanto, debe usar <main class = "contenedor"> en lugar de <div class = "contenedor"> . -La página debe contener un encabezado de nivel uno 'básicamente significa que su html debería tener una navegación de ayuda h1 de ayuda, por lo tanto<h2> mejorar sus habilidades front-end construyendo proyectos </h2>debería ser<h1 > Mejore sus habilidades de front-end creando proyectos </h1>y también debe bajar ordenado cuando esté utilizando los encabezados h1 hasta h2 hasta h3, y así sucesivamente.

    Esto debería solucionar la mayoría de sus problemas de accesibilidad.

    . Independientemente de que lo hicieras increíble ... ** Espero que encuentres esto útil ** ... ¡feliz codificación!

    0