Skip to content
Submitted over 2 years ago

HTML5, CSS, Flexbox

Chaitali•10
@chaitalikarmakar
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Hello,

I am new to front end development and practicing to get better. This is one of the first challenges I took from frontend mentor. Please review and let me know how I can do better.

Thank you.

Community feedback

  • Abdul•8,540
    @SamadeenPosted over 2 years ago

    Hey!! Cheers 🥂 on completing this challenge.. .

    Lets firstly work on your accessibility issues.

    • Document should have on main landmark basically means your html should be structured more semantically and the correct format should be your <header>......</header> followed by your <main>......</main> and lastly your <footer>....</footer> hence you should use <main class="background-layout"> instead of <div class="background-layout">.
    • Page should contain a level-one heading basically means your html should have a h1 it aid navigation hence <h3>Improve your front-end skills by building projects</h3> should be <h1>Improve your front-end skills by building projects</h1> and you should also go down orderly when you are using the headings h1 down to h2 down to h3 and so on.

    This should fix most of your accessibility issues.

    . Regardless you did amazing... hope you find this helpful... Happy coding!!!

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord