NFT Card - Using SASS, BEM

Community feedback

• 

  Abdul•8,540

  @SamadeenPosted over 2 years ago

  Hey!! Cheers 🥂 on completing this challenge.. .

  Lets firstly work on your accessibility issues.

  • Document should have on main landmark basically means your html should be structured more semantically and the correct format should be your <header>......</header> followed by your <main>......</main> and lastly your <footer>....</footer> hence you should use <main class="card"> instead of <div class="card">.

  • Your footer should be <footer class="attribution"> instead of <div =attribution>

  • Page should contain a level-one heading basically means your html should have a h1 it aid navigation hence <h2 class="card__heading">Equilibrium #3429</h2> should be <h21class="card__heading">Equilibrium #3429</h1> and you should also go down orderly when you are using the headings h1 down to h2 down to h3 and so on.

  • Images must have alternate text - Its hard for screen readers to pick up messages from images without alt text.. Its always advisable to include alt text to aid screen reader

  This should fix most of your accessibility issues.

  . Regardless you did amazing... hope you find this helpful... Happy coding!!!

  Marked as helpful

  1

  ---

  

  MohammedC4r•10

  @MohammedC4rPosted over 2 years ago

  @Samadeen Thank you firend🥂

  0