Design comparison
SolutionDesign
Community feedback
- @SamadeenPosted over 2 years ago
Hey!! Cheers 🥂 on completing this challenge.. .
Lets firstly work on your accessibility issues.
Document should have on main landmark
basically means your html should be structured more semantically and the correct format should be your<header>......</header>
followed by your<main>......</main>
and lastly your<footer>....</footer>
hence you should use<main class="container">
instead of<div class="container">
.
This should fix most of your accessibility issues.
. Regardless you did amazing... hope you find this helpful... Happy coding!!!
Marked as helpful0@ledxsPosted over 2 years ago@Samadeen Thank you so much.. I do appreciate your feedback. Yes, I just noticed that when I saw other projects posted from the community. I just started and this is just my second project but it is important to keep those good practices that you mention! Thank you!!!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord