Design comparison
Community feedback
- @SamadeenPosted over 2 years ago
Hey!! Cheers 🥂 on completing this challenge.. .
Lets firstly work on your accessibility issues.
-
Document should have on main landmark
basically means your html should be structured more semantically and the correct format should be your<header>......</header>
followed by your<main>......</main>
and lastly your<footer>....</footer>
hence you should use<main class="card">
instead of<section class="card">
. -
Your
footer
should be<footer class="attribution">
instead of<div =attribution>
-
Page should contain a level-one heading
basically means yourhtml
should have ah1
it aid navigation hence<h1 class="big-text"> Equilibrium #3429 </p>
should be<p class="big-text"> Equilibrium #3429 </h1>
and you should also go down orderly when you are using the headings h1 down to h2 down to h3 and so on.
This should fix most of your accessibility issues.
. Regardless you did amazing... hope you find this helpful... Happy coding!!!
Marked as helpful0@kinjamesPosted over 2 years ago@Samadeen Thank you so much for your feedback. I will make the necessary changes on it. I really appreciate it.
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord