Single price grid component

Community feedback

• 

  Ahmed Bayoumi•6,740

  @Bayoumi-devPosted over 2 years ago

  Hey Pedro, Congratulations on completing this challenge... You have accessibility issues that need to fix.

  • Document should have one main landmark, Contain the component with <main>.

  <main>
     <div class="grid">
        //...
     </div >
  </main>
  

  • Heading levels should only increase by one, Use h2 instead of h3... Ordered headings make it easier to navigate and understand when using assistive technologies.

  • I suggest you put the Why Us content into the list item to add more semantics to your project.

  <ul class="why-us-list">
     <li>Tutorials by industry experts</li>
     <li>Peer & expert code review</li>
     <li>Coding exercises</li>
     <li>Access to our GitHub repos</li>
     <li>Community forum</li>
     <li>Flashcard decks</li>
     <li>New videos every week</li>
  </ul>
  

  I hope this is helpful to you... Keep coding👍

  1
• 

  Abdul•8,540

  @SamadeenPosted over 2 years ago

  Hey!! Cheers 🥂 on completing this challenge.. .

  Lets firstly work on your accessibility issues.

  • Document should have on main landmark basically means your html should be structured more semantically and the correct format should be your <header>......</header> followed by your <main>......</main> and lastly your <footer>....</footer> hence you should use <main class="grid"> instead of <div class="grid">.
  • You should also go down orderly when you are using the headings h1 down to h2 down to h3 and so on.

  This should fix most of your accessibility issues.

  . Regardless you did amazing... hope you find this helpful... Happy coding!!!

  0

  ---

  

  Ahmed Bayoumi•6,740

  @Bayoumi-devPosted over 2 years ago

  @Samadeen I already suggested how to solve the issues What point is valuable and different in your suggestions?!!!!

  0

  

  Abdul•8,540

  @SamadeenPosted over 2 years ago

  @Bayoumi-dev Excuse you?? Do you want 1st so bad i can actually back down bro.. No need to come at me like that..

  0