Deshire Rivas• 20
@Deshire
Submitted
Please provide feedback to see what I can improve! Thank you!
Idev
@IDev11
All comments
- Idev• 200
@IDev11
Posted
Hi @Deshire, how are you?
You did a great job on this challenge, but I have a few tips that I think you'll like.
1- Document should have one main landmark, you could have put all the content inside the main tag check this https://dequeuniversity.com/rules/axe/4.3/landmark-one-main?application=axeAPI
2- you can always check the generated report above, it will really help you.
The rest is great, I hope it helps!!
Marked as helpful
0 - Givi J.• 130
@WhiteFatal
Submitted
This is my first try. Please let me know is it worth to continue?
Idev• 200@IDev11
Posted
Hi @WhiteFatal, how are you?
You did a great job on this challenge, but I have a few tips that I think you'll like.
1- Document should have one main landmark, you could have put all the content inside the main tag check this https://dequeuniversity.com/rules/axe/4.3/landmark-one-main?application=axeAPI
2- You can use relative units as rem or em that have a better fit if you want your site more accessible between different screen sizes and devices. REM and EM does not just apply to font size, but to all sizes as well.
3- you can use flex, it is more efficient in positioning your elements and also for responsive design.
4- you can always check the generated report above, it will really help you.
At the end of course it is worth to continue hahaha, keep going my friend!! The rest is good, I hope it helps!!
Marked as helpful
0 @regal-shabazz
Submitted
Idev• 200@IDev11
Posted
Hi @regal-shabazz, how are you?
You did a great job on this challenge, but I have a few tips that I think you'll like.
1- Document should have one main landmark, you could have put all the content inside the main tag check this https://dequeuniversity.com/rules/axe/4.3/landmark-one-main?application=axeAPI
2- You can use relative units as rem or em that have a better fit if you want your site more accessible between different screen sizes and devices. REM and EM does not just apply to font size, but to all sizes as well.
The rest is good, I hope it helps!!
Marked as helpful
0- Ioan• 300
@ioangheraszim
Submitted
Idev• 200@IDev11
Posted
Hi @ioangheraszim, how are you?
You did a great job on this challenge, but I have a few tips that I think you'll like.
1- Document should have one main landmark, you could have put all the content inside the main tag check this https://dequeuniversity.com/rules/axe/4.3/landmark-one-main?application=axeAPI
2- You can use relative units as rem or em that have a better fit if you want your site more accessible between different screen sizes and devices. REM and EM does not just apply to font size, but to all sizes as well.
The rest is great, I hope it helps!!
0 - Mileenka• 80
@Mileenka
Submitted
Idev• 200@IDev11
Posted
Hey Mileenka, how are you doing?
Your solution is excellent, I like it!
But I have some few tips that might help :
1- the square width and height needs to be 300px so that it can cover the whole image when you hover over it.
2- You can use relative units as rem or em that have a better fit if you want your site more accessible between different screen sizes and devices. REM and EM does not just apply to font size, but to all sizes as well, check this video from Kevin Powell https://youtu.be/N5wpD9Ov_To
The rest is great! Happy coding.
Marked as helpful
1 - Uzair• 340
@uzairK134
Submitted
Idev• 200@IDev11
Posted
Hey @uzairK134 , how are you doing?
I saw the preview of the site, and you did a great job on this challenge, but I have a few tips that I think you'll like.
1- Document should have one main landmark, you could have put all the content inside the main tag.
2- you can check the report above, it will help you.
The rest is great!! Hope it helps.
0 - Marko Djurdjevic• 210
@Frozennn
Submitted
Here is my solution to this challenge.
Any feedback or suggestion is more than appreciated :)
Idev• 200@IDev11
Posted
Hey @Frozennn, I hope you are doing great!
Congrats on finishing another challenge! I saw the preview of the site and I liked it a lot, everything was in its place, good job.
I just want to give you some tips that might help you :) , I saw you using only div and section tags, you can improve it using semantics tags to describe what is inside each block of content. You can replace the <div> that wraps each card with <article>, you can wrap the paragraph with the quote with the tag <blockquote> this way you'll wrap each block of element with the best tag in this situation. Pay attention, that <div> is only a block element without meaning. The rest is great!! I hope this will help you, and happy coding.
Marked as helpful
0 - Hicham Maachou• 40
@hichammaachou
Submitted
hello everyone, second time here wasn't very challenging. Looking for feedback that would help me improve. Thank you!
Idev• 200@IDev11
Posted
Hey @hichammaachou, I hope you are doing well! Great work I love the final result, if you are looking for feedback you may check the report in the solution page here, you will find some notes that you can use. Else everything is good for me hahaha I'm still a beginner, so you may get some advanced feedback from a more professional person soon. Great job, happy coding and good luck!
Marked as helpful
0 @barbara-teresa-toledo
Submitted
Idev• 200@IDev11
Posted
Hey @barbara-teresa-toledo, great job! I like the fact that you used flex-box, instead of position proprieties (relative, absolute …etc), you may check the report in the solution page here, there are some things you can adjust, for example you could have changed that H3 tag to an H1, because the page should contain a level-one heading, check this (https://dequeuniversity.com/rules/axe/4.3/page-has-heading-one). The rest is perfect!! Happy coding and good luck!
Marked as helpful
0
