@correlucas
Posted
👾Hi Deshire, congratulations for your first solution!👋 Welcome to the Frontend Mentor Coding Community!
Great solution and great start! By what I saw you’re on the right track. I’ve few suggestions to you that you can consider to add to your code:
1.Use <main>
instead of <div>
to wrap the card container. This way you show that this is the main block of content and also replace the div with a semantic tag.
2.I saw that for some properties you’ve used rem
and for others px
. In this case it is better to use only one kind of unit to have a better organization for your code. relative units
as rem
or em
that have a better fit if you want your site more accessible between different screen sizes and devices. REM
and EM
does not just apply to font size, but to all sizes as well.
3.Save your time using a CSS RESET to remove all default settings that are annoying as the margins, paddings, decorations and optimize it making easier to work,see the article below where you can copy and paste this css code cheatsheet: https://piccalil.li/blog/a-modern-css-reset/
✌️ I hope this helps you and happy coding!
Marked as helpful
@Deshire
Posted
@correlucas thanks for the comment. i will modify it