Submitted about 2 years ago

QR code component made with HTML and CSS

Givi J.• 130

@WhiteFatal

Preview site(opens in new window)View code(opens in new window)

This is a solution for...

QR code component

HTML
CSS

1newbie

View challenge

Design comparison

SolutionDesign

Solution retrospective

This is my first try. Please let me know is it worth to continue?

Community feedback

Idev• 200

@IDev11

Posted about 2 years ago

Hi @WhiteFatal, how are you?

You did a great job on this challenge, but I have a few tips that I think you'll like.

1- Document should have one main landmark, you could have put all the content inside the main tag check this https://dequeuniversity.com/rules/axe/4.3/landmark-one-main?application=axeAPI

2- You can use relative units as rem or em that have a better fit if you want your site more accessible between different screen sizes and devices. REM and EM does not just apply to font size, but to all sizes as well.

3- you can use flex, it is more efficient in positioning your elements and also for responsive design.

4- you can always check the generated report above, it will really help you.

At the end of course it is worth to continue hahaha, keep going my friend!! The rest is good, I hope it helps!!

Marked as helpful

Lucas 👾• 104,420

@correlucas

Posted about 2 years ago

👾Hi Givi J., congratulations for your first solution!👋 Welcome to the Frontend Mentor Coding Community!

Great solution and great start! By what I saw you’re on the right track. I’ve few suggestions to you that you can consider to add to your code:

1.Use <main> instead of <div> to wrap the card container. This way you show that this is the main block of content and also replace the div with a semantic tag.

2.Replace the <p> containing the main title with <h1> note that this title is the main heading for this page and every page needs one h1 to show which is the most important heading. Use the sequence h1 h2 h3 h4 h5 to show the hierarchy of your titles in level of importance, never jump a level.

3.The html structure is fine and works, but you can reduce at least 20% of your code cleaning the unnecessary elements, you start cleaning it by removing some unnecessary <div>. For this solution you wrap everything inside a single block of content using <div> or <main> (better option for accessibility) and put inside the whole content <img> / <h1> and <p>.

<body>
<main>
<img src="./images/image-qr-code.png" alt="Qr Code Image" >
 <h1>Improve your front-end skills by building projects</h1>
<p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
</main>
</body>

✌️ I hope this helps you and happy coding!

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord