@correlucas
Posted
👾Hello @ioangheraszim, Congratulations on completing this challenge!
Here's some tips for you:
1.The box-shadow is a bit too strong, this is due the opacity
and blur
. The secret to create a perfect and smooth shadow is to have low values for opacity
and increase blur
try this value instead: box-shadow: 12px 7px 20px 6px rgb(57 75 84 / 8%);
If you’re not familiar to box-shadow you can use this site to create the shadow design and then just drop the code into the CSS: https://html-css-js.com/css/generator/box-shadow/
2.The html structure is fine and works, but you can reduce at least 20% of your code cleaning the unnecessary elements, you start cleaning it by removing some unnecessary <div>
. For this solution you wrap everything inside a single block of content using <div>
or <main>
(better option for accessibility) and put inside the whole content <img>
/ <h1>
and <p>
.
<body>
<main>
<img src="./images/image-qr-code.png" alt="Qr Code Image" >
<h1>Improve your front-end skills by building projects</h1>
<p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
</main>
</body>
3.You’ve used px
as the unit for sizes but the problem with pixels is that its not optimized for multiple devices and screens. So a good fit its to use rem
or em
that have a better performance and make your site more accessible between different screen sizes and devices. REM
and EM
does not just apply to font size, but to all sizes as well.
✌️ I hope this helps you and happy coding!