Design comparison
Community feedback
- @correlucasPosted about 2 years ago
๐พHello @Mileenka, Congratulations on completing this challenge!
Nice code and nice solution! You did a good job here putting everything together. Iโve some suggestions for you:
1.Add transitions to make the interaction smoother while the element gets hovered, you can use a value like
transition: all ease-in 0.5s
.2.Add a margin of around
margin: 20px
to avoid the card touching the screen edges while it scales down.3.Use units as
rem
orem
instead ofpx
to improve your performance by resizing fonts between different screens and devices.To save your time you can code your whole page using
px
and then in the end use a VsCode plugin called px to rem here's the link โ https://marketplace.visualstudio.com/items?itemName=sainoba.px-to-rem to do the automatic conversion or use this website https://pixelsconverter.com/px-to-remโ๏ธ I hope this helps you and happy coding!
Marked as helpful1@MileenkaPosted about 2 years ago@correlucas @IDev11
Thank you very much for your help. Already corrected. I made the transition, included a margin and converted px to rem. Thank you for the VSC plugin. It turned out to be very helpful.
Have a nice morning and for the rest of the day :)
2 - @IDev11Posted about 2 years ago
Hey Mileenka, how are you doing?
Your solution is excellent, I like it!
But I have some few tips that might help :
1- the square width and height needs to be 300px so that it can cover the whole image when you hover over it.
2- You can use relative units as rem or em that have a better fit if you want your site more accessible between different screen sizes and devices. REM and EM does not just apply to font size, but to all sizes as well, check this video from Kevin Powell https://youtu.be/N5wpD9Ov_To
The rest is great! Happy coding.
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord