Design comparison
Solution retrospective
hello everyone, second time here wasn't very challenging. Looking for feedback that would help me improve. Thank you!
Community feedback
- @hyrongennikePosted about 2 years ago
Hi @hichammaachou,
Congrats it looks good, just add a
min-height: 100vh
on the main element instead ofheight: 100vh
the latter results in content overflowing and just add a bit more space around the card on mobile. The other thing I would advise is to always look at report first and fix those error if you correct them once you won't have any error in you're in the future challenges because you'll know what to do and what not to do.Marked as helpful0@hichammaachouPosted about 2 years ago@hyrongennike thank you for the feedback, that was very helpful!
0@hichammaachouPosted about 2 years ago@hyrongennike thank you for the feedback, that was very helpful!
0 - @IDev11Posted about 2 years ago
Hey @hichammaachou, I hope you are doing well! Great work I love the final result, if you are looking for feedback you may check the report in the solution page here, you will find some notes that you can use. Else everything is good for me hahaha I'm still a beginner, so you may get some advanced feedback from a more professional person soon. Great job, happy coding and good luck!
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord