@soransh-singhSubmitted about 4 years ago
Latest solutions
Latest comments
- @Greeshma2903Posted about 4 years ago
Hey Soransh!
Nice work, but you have scope for improvement 😊. I am no expert, but being part of this community, I'll be happy if I could be any help!
First up, you can clear the Accessibility and HTML issues that have been pointed out 👆. I think your main focus with this project was on CSS and not the functionality (through JS) because while clicking on the button, the page got redirected, instead of a page reload.
With regard to your code, I recommend using shorthand property over specific properties (increases readability), for eg : instead of
padding-left: 30px;padding-right: 30px;padding-bottom: 6px;you can use,padding : 0px 30px 6pxGood work with the background there! Happy coding 😄👍
2 - @azurasanSubmitted over 4 years ago@Greeshma2903Posted over 4 years ago
Good work with the design,
- you can add some more margin top and bottom margin to the
.container, for a cleaner look - maybe you can add
overflow: autotocontainer, to enable the scroll option for smaller screens. Happy coding! :)
1 - you can add some more margin top and bottom margin to the
- @NohaFahmiSubmitted over 4 years ago@Greeshma2903Posted over 4 years ago
Good start with Bootstrap!
You can add a class to
container-fluid, and add some margin to the page, to make it look cleaner.happy coding!!
1 - @umarbashirrSubmitted over 4 years ago
- @marawanmohamed9876Submitted over 4 years ago@Greeshma2903Posted over 4 years ago
the site is quite responsive! Good one. Keep going! All the best!
1 - @Aryan-desaleSubmitted over 4 years ago@Greeshma2903Posted over 4 years ago
That's a really cool hover effect on the buttons!
1
