@soransh-singhSubmitted almost 4 years ago
I am newbie to frontend development , It will be great help If you can have a look on my code and tell whether I am using best practices or not
Griselda Knight
@Greeshma2903All comments
- @Greeshma2903Posted almost 4 years ago
Hey Soransh!
Nice work, but you have scope for improvement 😊. I am no expert, but being part of this community, I'll be happy if I could be any help!
First up, you can clear the Accessibility and HTML issues that have been pointed out 👆. I think your main focus with this project was on CSS and not the functionality (through JS) because while clicking on the button, the page got redirected, instead of a page reload.
With regard to your code, I recommend using shorthand property over specific properties (increases readability), for eg : instead of
padding-left: 30px;padding-right: 30px;padding-bottom: 6px;you can use,padding : 0px 30px 6pxGood work with the background there! Happy coding 😄👍
2 - @azurasanSubmitted about 4 years ago
Give me feedback about my solution :)
@Greeshma2903Posted about 4 years agoGood work with the design,
- you can add some more margin top and bottom margin to the
.container, for a cleaner look - maybe you can add
overflow: autotocontainer, to enable the scroll option for smaller screens. Happy coding! :)
1 - you can add some more margin top and bottom margin to the
- @NohaFahmiSubmitted about 4 years ago
This is first time using bootstrap, I would love to get your feedback
@Greeshma2903Posted about 4 years agoGood start with Bootstrap!
You can add a class to
container-fluid, and add some margin to the page, to make it look cleaner.happy coding!!
1 - @umarbashirrSubmitted about 4 years ago
Hi Everyone! Hope you will like my work. Please do write your feedback about my work. Every single feedback will help me alot. Thanks
- @marawanmohamed9876Submitted about 4 years ago
any advice to make my website more responsive?
@Greeshma2903Posted about 4 years agothe site is quite responsive! Good one. Keep going! All the best!
1 - @Aryan-desaleSubmitted about 4 years ago
How's the hover effect of the buttons?
@Greeshma2903Posted about 4 years agoThat's a really cool hover effect on the buttons!
1 - @devhalimahSubmitted over 4 years ago@Greeshma2903Posted about 4 years ago
Hello! You can add some margin to the body, to make it resemble the given design a bit more.
0
