I attempted to build the Mobile design version first and it made things a little confusing for me when I attempted to add in the responsiveness once the Mobile design was complete.
If anyone has any tips or tricks on a Mobile First approach, please share.
Is it a good idea to have your project open and adjusted to the screen width recommened in the ReadMe (i.e 375px for Mobile) whilst you code ?
Thanks.
Hey, nice work on this one. The desktop layout looks good, however layout issues appears when resizing the browser from desktop view to mobile view as the layout is not responsive. Also, when you zoom out on your end, the components gets huge.
Ivan already gave great feedback on this one, just going to add some as well:
position absolute a large container on your site, on your end, using it on the main tag. The reason for this is that, position: absolute removes the element from the flow, if the container doesn't have explicit sizes, it makes the container doesn't "capture" the child element. Try to inspect your site in dev tools, hover on the body tag, you'll notice that it doesn't have any size because its child element is being absolute. For this one, you can just remove all these stylings on the main tag:position
top
left
bottom
right
margin
width
height
Then to properly center the content, add these first on the body tag:
align-items: center;
display: flex;
justify-content: center;
min-height: 100vh; # makes sure that it has sufficient height
padding: # add some to prevent component touching the sides of the browser
place-content: center;
Then again on the main tag, you can just add:
flex-basis: 100%;
max-width: 500px; # convert to rem and change the size depends on the design;
This makes the component more responsive. You can add min-height on the main as well if you want if you like a more consistent sizing.
main. Again, remove all those stylings I mentioned earlier on each element and let the main container handle their positioning. If you need to place elements, don't always jump to position: absolute this should be the last case you want. Try searching or maybe looking up other website's submission as well to get some ideas when you are coding :>id attributes to target an element on your css, using id creates problem due to specificity, always use class so that it could be more manageable and reusable.h1 is needed for every webpage, the h1 describes the main content per each page. On this one, since there are no visible h1 on the page, the h1 will be instead a screen-reader only h1. Meaning, it won't be seen visually, but it is there. Have a look at this simple fiddle that I have about screen-reader text. Comments are already included, but if you have any queries, just let me know okay.h4, use h2 on the "Advice" text. When you are using heading tags, make sure that they are on the proper level, when you use h4, make sure that h1, h2, h3 are all present before the h4.html, this will make screen-reader read the word letter-by-letter and not by word. Use lowercase on them and just use text-transform: uppercase on the css.main tag in the center, you can add:align-items: center;
display: flex;
flex-direction: column;
On the main tag.
img tag, always add an alt attribute. When you don't include it, screen-reader will instead announce something different from the file path. So always include it.img is just being used as decoration, adding alt="" and aria-hidden="true" on it would be nice. This makes the img tag be hidden for screen-readers as they are not really meaningful content of the site, always use this when image are not informative.input, using button would be much better and correct for this one since input are used inside of form right.button on that one, I would suggest the .circle selector to be the actual button, just style it to be circular. Also, since there are no visible text on that button ( if you used ), you should always add a label-text on it on what the button is supposed to do. For example, you can add aria-label="Change quote text". This way, when user traverses the button using screen-reader, they will be notified on what this button does.button is toggled or an alternative, aria-live would be use on the quote so that it will be easier to maintain response.Those might be lot but you'll encounter them on your way. Just let me know if you need help and see if I can help. Again, great job for this one.
Hi need advice for responsive font size 🙏
Hey, great work on this one. The desktop layout looks really nice, the site is responsive and the mobile state looks really nice as well.
Others already gave their feedback which is nice to see, just going to add some suggestions as well and don't mind me if I re-iterate some ideas mentioned already:>
scss part, you don't really need to use:body {
.... other selectors
}
You can just directly target the selectors like .container, this way you reduce specificity. Also, if you like, you can search about bem convention. This will help you manage css selectors and create more generic classes. For example, you will have something like:
.cards{
&__container {}
&__list{}
&__item{}
}
This way, you can group them properly if you think about it.
max-width on the body tag to prevent the layout from stretching. If you try to zoom out on your browser, you'll see that the layout stretches, adding max-width will prevent that, just make sure to add margin: 0 auto so that the body will be centered.Reliable, efficient delivery
Powered by Technology
Are just one single phrase, meaning instead of using p tag for the first one, use a single h1 to wrap both lines and just add max-width on the h1 so that it will limit and create that 2 lines.
font-sizes could be bigger, right now some text are small and they are smaller than the design as well.h1 for a site. The h1 typically use on the hero heading like the 2 lines above on the site. So each of the card titles could be replace by just h2.aria-hidden="true" attribute so that it will be totally hidden.Those only. Again, great job on this one.
Hi everyone,
I would appreciate any feedback you can offer.
Thanks.
Hey, really nice work on this one. Overall, the layout for both desktop and mobile state looks really great. The reply also works great as well the upvote and downvote.
For some suggestions, here are some:
h1 being sr-hidden. You can add clip: rect(0 0 0 0); on the h1 to fix it.+ or - alone is not enough. What you can do is that, add an sr-only text inside it to which could be downvote comment and upvote comment, depends on where it is placed.aria-live attribute on the element wrapping the counts so that assistive tech will announce the update to the user on what happened. You can add extra text if you want, an sr-only text. Also, you could change the span to just p tag.img, since their name is already present, it would great to use their name as the alt value since it makes sense to do so.a tag? Each person's img and name. Could be right.div. Changing all those div that wraps a text should be replaced by p tag.button, the arrow-svg should have an aria-hidden="true" attribute on it since it is only a decorative image.button, adding aria-expanded attribute would make it more accessible. This way, when a user toggles it, assistive tech will inform the user that it shows or expanding something.form, using the user's name on the user's avatar alt attribute would be nice.label for the textarea would be great. Remember to always add label for each input or textarea element. This way, when a user is using a different language, those label text will be changed as well since attribute's data is static, the placeholder won't be translated. The label will be sr-only on this one.textarea. Initially, it should be empty right because a user is still not typing anything, but since you are already adding the @_name on field, a user can press the reply to send that reply even if they haven't add anything on the textarea and it will be much confusing since it is using required and to be honest, I can't think of an approach on this one, so maybe just letting you know about this? :>>button it would be nice again to have an aria-live element or maybe you can add a toast-notification on this one. The toast's text-content will vary on the user's choice, it could be like successfully replied to {person's name} or could be like reply cancelled. Just remember to add an aria-live="polite" on the element so that it will be announced.button, it would be nice to set the focus to the modal. This way, user will immediately be informed on what is the content. Right now, if you use keyboard to toggle the delete, then tab again, the user won't traversed on the modal like what it should do. So when a user toggles the delete, add the aria-expanded attribute then shift the focus in the modal, so that if they tab again, they will tab inside the modal. Another feature to add as well is to have a trap focus inside the modal. Meaning they can only tab on the two options, this way the user won't be confused on where they are at now.aria-live on this one or some toast, for the successfully deleting a reply and adding a comment as well.Just in general, if there are lots of state in your app that requires to send an update to the user, an aria-live would be nice or sometimes changing the focus on the pop-up element is really nice.
Aside from those, great job again on this one.
Hello Frontendmentors. I am back with a new design that I tried my hands on. I am currently Learning JavaScript so I tried myJavaScript skills on this design and it was successful . I also added a CSS animation to the dropdown any suggestion about that also?
#1. I found it difficult positioning Images as to how the design looks. Working with Images Is complicated.
#2.I am unsure about the media breakpoints between mobile and desktop which is the Tablet. Please anybody? what do you think about the breakpoints. or what do you suggest.
#3. Is it a best practice to set a min-height for a flex or grid container?
Hey, nice work on this one.
For desktop layout, I think it looks fine, just needed for the proper font-weight to be used and also the svg's outline is overflowing, on the original, the outline should be cut. The mobile state looks fine as well.
On your questions:
position: absolute something but I think that you did great on this one!768px for the tablet and 1000px on desktop state, I always start now with mobile first approach. Sometimes this changes because like I said, it depends on the layout.body to occupy the full height.Here are some other suggestions for the site:
alt attribute and adding an extra aria-hidden="true" attribute on the img would be nice. On this one, the lady illustration should be using those attributes I mentioned since it is only decorative.alt values for images that are really meaningful on the site and when adding the text, the text should not include words that relates to graphic such as illustration, image, icon since the img tag is already a graphic and no need to describe it as one.h2 into using button or maybe just use a details element on this one. When creating applications or websites, if a component is interactive, always use interactive elements like button. I saw that you are using the div as a toggle for the content which should not be the case.overflow and max-height but a user can still traverse those. If you need to hide an element, adding the visibility: hidden should be done and visibility: visible if it needs to be shown.Aside from those, great job again on this one. Let me know if you need any help.
hello everyone! this is my attempts of the template any feedback will be nice.. and if somebody knows how to increase SEO will be nice if you share it with me :)
Hey, nice work on this one.
For the layout, on desktop view maybe adjusting the padding would be nice. If you look at the design, there is a fixed padding on the left and right side for each of the landmark elements, you can follow that to improve the ui. Some text as well got smaller after the hero section. For mobile state, I think it looks fine.
Here are some suggestions besides Divine Obeten feedback:
aria-label or an sr-only text inside it so that a user will know where the link would take them. You do this when there are no text-content inside the anchor. For this one, you can use like aria-label="homepage" on the a tag.alt="Huddle".nav if you want since it is being treated as link. But to be honest, I think you can just replace the nav by just a div since the link/s inside is not much, the nav would be much better on the links inside the footer tag.height: 100vh on an element, this will make the element's height not consistent. Try going into dev tools at the bottom, you will notice that the hero section's height got small because of this property. Instead, use min-height: 100vh so that the container will respond properly.section tags into just div because section alone is not that informative as a landmark element. By navigating using screen-reader, when it traverses the section tag, it won't announce it as a landmark even if you are traversing it as a landmark compared to like main, header and footer. div would be fine^^br tag to cut the text, you can just add max-width on the text-element.aria-hidden="true" attribute on the img tag so that it will be completely hidden for other assistive tech. You can this as well on the svg's that are used across the page.FOOTER
On the logo, you are trying to make it white right, adding background-color to img won't work. What you can do is that add the svg's code itself on your html, then change the fill property of either the svg or path I think to the color that you want and this will changed the svg's color.
Same goes again for the logo-link, use a text that describes where the link would take and use the site's name as the alt value.
Those 6 links are all related to one another and using a single ul to wrap them would be better and also, you can wrap that ul tag by nav tag since those are the site's navigational links.
Those social media links could be wrapped inside a ul tag as well since they are list of links.
Since you are adding a hover state for the social media, you are implying that those are interactive, hence wrapping those inside their own a tag would be better, added as well the sr-only text or aria-label pointing on where it would take the user.
Lastly, if you pushed an update to your solution, clicking again the generate report so that it will clear up some issue if you fixed it.
Aside from those, great job again on this one.
Hello, how do you see the page?
I did my best, I'm learning javascript and I think the javascript code could have been better but that's what I was able to do. Any advice on what could be improved would be helpful, thanks!
Hey, nice work on this one. The layout for the desktop is fine but it could use more width since it is small right now. Resizing the site, it works fine but the layout at 1000px below until mobile state, the layout doesn't respond well making each content of the main squished and at 600px to 800px, you will noticed that the text on the left are now being overlapped by the form. The mobile state looks great though.
Here are some suggestions for the site:
height on the body tag. I'm supposing that you want the body to take the full height right, instead of using height, use min-height so that whenever the content of the site gets bigger, the body will rescale to that size because min-height lets the element expand unlike height that gives a fixed size.width for each child of main, you can just use padding and maybe add a max-width on the body tag so that it will prevent the layout to just always take full width of the user's screen. Just make sure to add margin: 0 auto for it to be centered.section tag into just using div. Using section is not really informative at all as landmark because it doesn't give extra information about it when traversing using an assistive tech, unless you give an aria-labelledby to it pointing to an heading's id. div is much better to wrap contents.input tag, adding a label pointing to it will be great so that even if the user uses a different languages, text content on the site can change if they want to translate the text and values used in attributes like the placeholder or maybe an aria-label are not translatable. Adding the label on this with an sr-only class will be great.input, use button type="submit" to be more explicit.SUBMITTING A WRONG FORM
input is invalid, adding an aria-invalid to that input would be really great so that when the user traverses on it, they will be notified that the input is wrong.id. I would change the div into just using p tag since it is a text content. Each error messages should have an id to which will be referenced by the input using the aria-describedBy attribute. This way, the user will know what kind of error that they had made because of the error message. Each id should be distinct like id="firstName-error".aria-live inside the form. The text will vary according to the form's submission, it could either be something like form has been submitted, thank you or it could be form submission invalid, please check your first name, last name... inputs.Here is a sample block that uses the attributes to add each error:
if ( input is invalid ) {
input.setAttribute("aria-invalid", "true");
input.setAttribute("aria-describedBy", id of the error message");
} else {
input.removeAttribute("aria-invalid");
input.removeAttribute("aria-describedBy");
}
Here is a sample form submission of what I said. It is a simple accessible form that I created, the aria-live is implemented there as well. Let me know if you have questions about it^^
Still, great work on this one.
Hello my community,
kindly review my solution and share your tips and feedback on how to improve my design and code.
Thanks 2div
Hey, nice work on this one. I see that you somehow went on another approach on this one, it's fine but I really recommend that when you tackle other challenges, following the design itself should be the best ui approach :>
Here are some other suggestions besides Deniel helpful suggestion and don't mind me reiterating some already suggested ones:
main tag on the .container instead of div would make the site more accessible. When creating websites, you should use main tag to nest the main-content of that webpage, on this case, the whole content should be inside the main.margin on the .container since it is not really consistent. What you can do is that, add these stylings on the .container:justify-content: center;
min-height: 100vh;
This way, the item will be centered properly and dynamically.
margin on the .card could be removed since its parent ( .container) is already making it centered.img, you could just use alt="" and aria-hidden="true" on it since the image doesn't really depict anything visually and could just be left empty so that screen reader won't read it.img or svg , you don't use words that relates to graphic like "image"` since those elements are already graphics.h1 on it for now. Remember that a webpage needs to have an h1 and you can replace the p tag with it on this.p tag, change your span into using p tag.Aside from those, great job again on this one^^
how i know the exactly size of the sections on the practice?
Hey, really nice work on this one. I think the layout for desktop looks nice, the site is responsive as well when scaling the browser. For mobile state, there are breakpoints where you already show the one-column layout for the mobile view, yet there are still section where the contents are still using the desktop version. For example, at 700px, for the features section, the tab-controls are in a single column-layout but the content underneath is still using the desktop version. It would be nice to just show both the mobile version for each content. Also, at the 700px, the navbar's login wraps on another row.
Here are some other suggestions for the site:
max-width on the body tag or in a wrapper for the content. If you try to zoom out on your screen, you will see that the site's content are just stretching along. Adding the max-width will prevent this one.outline: none on the * selector if you aren't going to provide a custom visual-indicator. The outline provides guide to the user when traversing focusable elements on the site. Try using the tab key to navigate the site, it is hard to know where you are at. Use the :focus-visible selector to add the custom outline or just remove your declaration.body doesn't need to use a flexbox since the content of the site are just sitting on a single-column. Also, your html elements that are nesting the site's content right now are just being direct child of the body which should not be since they should be nested inside their own landmark element.header, the main-content inside the main tag and the bottom-most part inside the footer tag. Your body tag should only contain these 3 landmark element:<header />
<main />
<footer />
nav to create the mobile and desktop version of the navbar which shouldn't be the the case. You should only use a single nav and just use css to make it adapt for mobile and desktop state. This way, your markup won't be using repetitive element.nav, right now, the mobile-state nav is not being hidden properly. When you are making something hidden, you don't just use the width or opacity as they are only hiding the content visually but they are still in the dom. You should always use visibility or display to show/hide the item.nav element could use an aria-label="primary" attribute on it. The reason for this is that, I would later suggest nav on the footer tag. You should add the aria-label for a nav element if you are using the nav more than once on the page. This will make it unique.nav since it is not being treated as a site-link.alt for the site-logo, always make sure to use the website's name and not just logo because if a user traverses the images on the site, what does logo text will provide really. Also, avoid those words that relates to graphic when using value for the alt attribute.ul tag since those "list" of links.text-transform: uppercase in css.login is better using a tag rather than button on this one.a tag inside the button and vice versa as they just create 2 extra traversing. Use only a single one.header inside the main as it is as it will be treated as a regular element. It would be better if it was replaced by div.br tag to make the word wrapped in another row like what you used in the h1 tag. Use max-width for the h1 so that it will make the word wrapped if it needs.aria-hidden="true" attribute so that it will be totally hidden for screen-reader users.article for the features use a single article to wrap both the tab-controls and the content below since they are related to one another.features section as well, your controls are working fine but using button alone without any extra attributes addition is not informative at all. For this one, you can implement it as tabbed interface. You can have a look at my implementation on my solution for this. This way, it will be more accessible for the users.more info should be using a tag since it is more likely to be link.br tag to make each text wrapped. Again, max-width will be much better.section tag but used incorrect. section tag as landmark is not really informative as it does not give extra information about the tag unless
you are using aria-labelledby attribute on it. This way, it will read out the heading tag to which it points to. If the section ( not section tag ) of the site doesn't have a visible heading text, a div would be fine.faq section, you don't use a tag to wrap the whole accordions. Use only a tag for contents that will navigate a user in a different page of the site of just navigate them elsewhere. A div replacement will be much better on this.max-height. Remember to use the above method I mentioned. If you don't want the trouble on this, use details tag instead. It is already accessible and is suited for this kind of structure.cta section, your input right now currently lacks associated label to it or an aria-label to which will define the purpose of the input element. Always include it so that user will know what they need to give on each input. Make sure that label is pointing to the id of the input as well.input properly. A proper way of validating it would look like this:if ( input is wrong )
input.setAttribute("aria-invalid", "true");
input.setAttribute("aria-describedBy", id of the error-message);
else
input.removeAttribute("aria-invalid");
input.removeAttribute("aria-describedBy");
The error-message element should have an id attribute which is referenced by the aria-describedBy attribute on the input element. By doing that, your user will know that the input is wrong because of aria-invalid and they will know what kind of error they made because of the aria-describedBy.
aria-live element that will either announce if the form submission is a success or not. This way, the user will be informed right-away on what is the status of the submission.button should have type="submit". Remember that when a button is placed inside a form element, it defaults to type="submit". So imagine if you have a close-button inside the form without specifying type="button" clicking the close-button will submit the form. Be aware of this kind of scenarios.FOOTER
alt value.nav element since those are still your site's navigational links. The nav would have an aria-label="footer" to it so that it will be unique.ul since they are "list" of links. They are just the same structure as the header's navbar.ul element since those are "list" of links.a tag that wraps the social-media icon should have either aria-label attribute or sr-only text inside it, defining where the link would take them. For example, you should use facebook as the value if the link would take the user to facebook.alt="" and aria-hidden="true".MOBILE
button since it is an interactive component. When creating interactive component, make sure that you are using interactive element so that it will be accessible for other users.SUPPOSING BUTTON IS USED
button should have a default attribute of aria-expanded="false" and it will be set to true when the users toggles it and vice-versa.button should have either aria-label attribute or sr-only text inside it which defines what the button does. You could use aria-label="navigation dropdown menu"img inside the hamburger-menu should have been hidden since it is only a decorative image.tab key, the focus will be set on the dropdown.Now, it is fine to have those lots of issues. Just always be aware in this kind of scenario and always try to aim accessible site. You can always take look at other people's solution or just search on the net for proper markup on a specific layout.
Aside from those, great job again on this one!
Looking for feedback and anything that I could of done better.
Hey, awesome work on this one and congrats as well for your first challenge here at FEM! Hope you had fun doing this challenge and learned from it:>. For desktop layout, it just needed it to be centered and it's good to go.
Here are some other suggestions for the site:
html {
box-sizing: border-box;
font-size: 100%;
}
body {
margin: 0;
}
*,
*::before,
*::after {
box-sizing: inherit
}
This way, handling an element specially its size will be easier because of the box-sizing
main tag so that it will be easy for the user to know and navigate on the main landmark. For this one, create a main tag that will wrap the 3 card.body will just ruin it. But if you manage to create a main, then use:align-items: center;
display: flex;
flex-direction: column;
justify-content: center;
min-height: 100vh;
Styling on the body tag.
div card, instead of height use min-height. Using height will give an explicit /fixed sizing on the element making it not scale base on it's content, while min-height will allow the element to resize if needed..card that you can give on each of the card on the layout, this way you won't have to manually add the stylings on each of the sedan, suv, luxury selector.alt="" and aria-hidden="true" to the img tag or only aria-hidden="true" if you are using svg instead of img tag.h1 tag, usually it is the first heading tag inside the main tag. It describes the content of the site, but since there is no visible heading text on this one, you should create the h1 as screen-reader only h1. Have a look at this solution of Grace on the same challenge. Inspect the website and see how she used the h1 and the stylings applied to it.a tag rather than button because on a real site, those would be page links for the user to visit and "learn more" about a specific car.Aside from those, great job again on this one.
Any feedback will do. Thanks.
Hey, awesome work on this one. The desktop layout looks fine, just a little bit shorter. For responsiveness, if you go at 900px upwards, you will notice that the site hides the content and creates horizontal scrollbar. For mobile state, it looks fine but the top part is being hidden by the screen's ceiling.
Here are some suggestions for the site:
height: 100vh on a large container like the .wrapper container as this makes the element's height capped based on the viewport/screen's height. Instead use min-height: 100vh so that the element will expand if it needs to.alt on it if you find the image meaningful. Right now, the text office is too broad on what is image's content is all about.text-align should be set to left because right now, texts are centered., if you look at the content, those could be "list" of information about the company website, therefore you can use ul` tag on it.ul, those span would be li and also, using just a plan span to wrap a content is not that great, you should always put content inside of a meaningful element.Aside from those, great job again on this one.
Hi this is the third project I've been done building please give me a good review in this one even though this is not perfect. from the Philippines!
Hey, awesome work on this one. The desktop layout looks fine, it's just a bit taller and some white-spaces could be reduced as well. The site is responsive and the mobile state looks great.
Here are some suggestions for the site:
max-width on the body or in a container that holds content. If you try to zoom out on your screen, the content stretches along with the resize. Adding that max-width will prevent that and makes sure that the content will be consistent for the user.a tag should have either aria-label attribute or sr-only text inside, that describes where the link would take the user. Usually, website-logo directs user to homepage so use homepage as the value like `aria-label="homepage".alt for it. Use the website's name as the value like alt="clipboard".outline for the img since it is using margin-bottom which pushes it from the container. Use that styling on the a tag instead.section is not bad but you can just replaced it with just div if there is already an existing visible heading tag on that section ( not section tag ) since if you traverse the site using screen-reader with landmark, when the screen-reader traverses the section tag, it doesn't read out a label text that signifies it as a landmark, unless you are using like an aria-labelledby if you want the element given an importance to.h1 into just other heading tag. Using h1 inside a section, article is not bad as well but hey, we just want to stick out with the semantic markup :>alt="clipboard app running on mac desktop".alt="" and aria-hidden="true" to the img tag or only aria-hidden="true" if you are using svg instead of img tag.alt on images that are meaningful and adds content to the site otherwise hide the image for screen-reader users.img tag, you don't need to add words that relates to "graphic" such as "logo" and others, since img is already an image so no need to describe it as one.alt and remove the word logo.FOOTER
alt value.ul tag since those are related links. The ul could be wrapped inside by a nav tag since those are still your navigational links.ul element since those are "list" of links.a tag that wraps the social-media icon should have either aria-label attribute or sr-only text inside it, defining where the link would take them. For example, you should use facebook as the value if the link would take the user to facebook.alt="" and aria-hidden="true".Aside from those, great job again on this one.
Feedback would be highly appreciated especially on the javascript menu
Hey, awesome work on this one. The desktop layout looks fine for me, just that the hero-section is bit to taller, the text-alignment is using center instead of left and the white-spaces on the testimonial section could be reduce. For responsiveness, if you go at point 770px, you will notice that the site's content is being by the screen causing a horizontal scrollbar and the text of the site starts to get squished, the images doesn't respond and alignment is still not going well.
David Turner already gave a feedback on this one, just going to add some suggestions as well:
<header />
<main />
<footer />
This way, all content of your page will be inside their own respective landmark element. Remember that for the primary header, nest only the topmost part of the site which are the site-logo, navlinks and leave the hero-section inside the main tag because you want the header to be reusable for other pages, so only include what is needed on that.
nav since it is not being treated as a link. If you insist on doing so, it would be nice to wrap the img by a tag and make sure to properly use an aria-label or sr-only text that would describe where the link would take the user.header tag's nav, you can add aria-label="primary" so that it will be unique since a another nav could be used inside the footer tag.header could be wrap inside a ul tag since those are "list" of links.height: 100vw on the .h-screen selector. Avoid using height: 100vh as this makes the element's height capped based on the viewport/screen's height. Instead use min-height: 100vh so that the element will expand if it needs to.rem value to give the height on the hero-section instead of vh unit so that it will stay consistent for all user. Try to inspect the layout in dev tools at the bottom, the hero-section changes a lot when you resize the screen's height.alt="" and aria-hidden="true" to the img tag or only aria-hidden="true" if you are using svg instead of img tag.h1 since you don't want it to be repetitive on the page. Use a single h1 only and change those into other heading tags.text-align: left as well on each of the section after the hero so that it will look like the design.learn-more are better using a tag rather than button. On a real site, those would be page links and not like a control.alt attributes on the site-logo and each of the person's on the testimonial section and the rest would be hidden using the method above since they are all decorative images.background-image for each container so that they will be easier to handle.blockquote on a screen-reader:<figure>
<img src="" alt={person name}>
<blockquote>
<p> {qoute in here}</p>
</blockquote>
<figcaption>
person name
<p>
person role
</p>
</figcaption>
</figure>
FOOTER
background-color could be lighter so that it will match the footer's design.ul because again, they are "list" of links. Also, the ul on this could be wrapper inside a nav since they are still your site's navigation links. The nav should have aria-label="footer" so that it will be unique.ul element since those are "list" of links.a tag that wraps the social-media icon should have either aria-label attribute or sr-only text inside it, defining where the link would take them. For example, you should use facebook as the value if the link would take the user to facebook.alt="" and aria-hidden="true".MOBILE
button since it is an interactive component. When creating interactive component, make sure that you are using interactive element so that it will be accessible for other users.SUPPOSING BUTTON IS USED
The hamburger button should have a default attribute of aria-expanded="false" and it will be set to true when the users toggles it and vice-versa.
The hamburger button should have either aria-label attribute or sr-only text inside it which defines what the button does. You could use aria-label="navigation dropdown menu"
The svg inside the hamburger-menu should have been hidden since it is only a decorative image so use aria-hidden="true" on it.
Also, the placement of your hamburger and the dropdown is incorrect. The dropdown should be placed after the hamburger so that after the user toggles it, the next focus is on the dropdown.
Lastly, in general, adjusting the styling on the site and addressing the responsiveness issue:>
Aside from those, great job again on this one.