Latest solutions
Latest comments
- @SierLorSubmitted 4 months ago@UDsGitHubPosted 4 months ago
Take a look at my recent solution for this. Ignore the semantic issues, I will correct them soon enough. Some things I would like to comment on about your solution include:
- I assume you didnt get the figma design file just like me, but your spacing seems waay off. If you are using windows system, try downloading this app called PowerToys. It is useful for color picking, pixel measurements and more. I used it to get measurements for somethings in the design pictures and got a rough idea on what the sizes of things were.
- Might want to have transition duration on your interactive hover elements.
- Using an image for the svgs was the right call, but you dont exactly want to be specifying width and heights on the images, cuz that locks you into positions you dont want to be in, especially with this design. Setting a height was fine, but you would rather have 100% width on the svg images. For mine, I had them in divs, and the images set to object fit contain and let flexbox handle the sizing of the divs.
Hope this helps
Marked as helpful1 - P@gokhandemrSubmitted 4 months ago@UDsGitHubPosted 4 months ago
Very nice work here, the only thing I would recommend, is have more transitions on your hover state elements
1 - @kdumagalhaesSubmitted about 3 years ago@UDsGitHubPosted about 3 years ago
Hey Kadu, just saw your solution and it looks great. The one issue I found, was that it seems as though your main profile component isnt in the same container as the time tracking components as such, when the screen width changes below 1100px, it starts to break and look off.
Good luck with that, Id suggest having both the profile and the.... dont mind me. I just looked at the divs in your code and noticed I have said a bunch of stuff right now. Yeah so basically, your profile needs to be able to stretch with the rest of the components and look decent while at it.
Good luck 👍
1 - @akki251Submitted about 3 years ago@UDsGitHubPosted about 3 years ago
Hey man I just saw your solution to this challenge, and it looks great. the only thing I had to pick on, was the navmenu's responsive styling. When in mobile display size and the navmenu is opened, if the screen width changes back to desktop size, the navmenu as well as the hamburger menu remains open and visible. This is a slight bug you have to fix. Good luck 👍
1 - @CodeSenpai101Submitted over 3 years ago@UDsGitHubPosted over 3 years ago
Hey CodeSenpai, I saw your solution and it looks great. I really love the way you did the border of the card. The issues I noticed so far are:
- Your hover trigger is over the whole card instead of just the "Etherium" image.
- You could also add
cursor: pointer
to your hoverable elements that arent like that by default e.g, anchor tags. - You could add some vertical padding to your body so the attribution part isn't touching the bottom of the page. These are all I have to pick on at the moment, but you can start by taking a look at the report Frontend mentor gave you.
Good luck 👍
Marked as helpful1 - @AchrefFastSubmitted over 3 years ago@UDsGitHubPosted over 3 years ago
Hey man I really love your solution, and I have been spending the past few hours trying to study and learn from it. I am still hung up on how you made the number input appear without the increment, decrement stuff... I saw your code and it looks like you used appearance, but testing stuff out on codepen, it doesnt seem to work the same for me. Any advice?
0