@Sohila-SamirSubmitted over 2 years ago
any recommendation to improve the code?
MuhammadSamir
@Muhammad-samirAll comments
- @Muhammad-samirPosted over 2 years ago
first of all It looks great on the mobile view but you have to change the width for your #mobile element to 260px instead of 70%; and it will work and you should fix your Html issues and everthing will be great.
0 - @benwmxSubmitted over 3 years ago
I really appreciate any feedback. thanks :)
@Muhammad-samirPosted over 3 years agoEvery thing looks perfect but you have to make a {color:black;} and you should put button {cursor:pointer;} That's it and happy code
0 - @AyushDevkotaSubmitted over 3 years ago
Feedbacks are appreciated. Edit: For some weird reason the screenshot has the email sign-up near the footer completely wrong than what it is in the live site even though I've already generated a new screenshot.
@Muhammad-samirPosted over 3 years agoEvery thing looks good you just have to add img { max-width:100%} and you will see the magic
0 - @BonreySubmitted over 3 years ago
Hello there, everyone! 👋 Here's another CSS challenge I decided to tackle.
At first, I wanted to practice another CSS framework — Tailwind. However, I didn't find it very entertaining: looking up specific tailwind classes when I can just write my own styles, ugh. 😒
Don't get me wrong, I still learned a lot about Tailwind! In fact, it's the best CSS framework I tried. (As some of you know, I also tried Bootstrap and Bulma in the last couple of challenges.) It is very comprehensive: you get way more classes than in Bulma and can style your page with virtually no CSS! However, sometimes, there's still a need to apply a very specific value to
widthor use pseudo-classes (or -elements), for instance. Well, you see, no matter how extensive a certain framework is, plain CSS will always be more flexible. 😏So, I believe that from now onwards, I'll write my own styles, using SASS, and use CSS frameworks only for super-small projects.
Well, thanks for reading this long text till the end. 😅 And happy coding to all of you! 💻
- @olgak169Submitted over 3 years ago
All animations done with Sass. Would've been much easier and cleaner with JS, but I had to do it the hard way. Leave a feedback, I will be happy to hear your opinion! upd.alignment update
- @szcompanySubmitted over 3 years ago
Any feedback is appreciated. Thanks.
- @palgrammingSubmitted over 3 years ago
This is a really fun project. I think also doing the challenges on CSS Battle really helped me be able to knock this project out this time.
@Muhammad-samirPosted over 3 years agoGood job I think you have done a beautiful stuff but I think you forgot about box-shadow below the mobile and also there's a space in mobile view and you have to fix it
0 - @meijerestelleSubmitted over 3 years ago
Feedback is greatly appreciated! ✨
@Muhammad-samirPosted over 3 years agoGood job every thing perfect but I think you should add margin left to each elements to be centered and I think you have to change the color of the image Good luck
0 - @hacmaz123456Submitted over 3 years ago
I need more feedback, plz feedback for me thx :D
@Muhammad-samirPosted over 3 years agoEverything looks perfect in mobile view but I see you have to work on desktop view
1 - @kaiwalyakoparkarSubmitted over 3 years ago
I would love to get suggestions on my solution.
@Muhammad-samirPosted over 3 years agoYou forgot about social media buttons and you have to work on mobile view
0 - @axseingaSubmitted over 3 years ago
Hi there!
All comments welcome.
If anyone knows better way of creating share buttons please let me know, I am sure there is better way. I used one button but needed two functionalities depends on the screen size. I could not fine a solution so I 'faked' second button by adding it only when it is on mobile.
Thank you.
- @alyssieSubmitted over 3 years ago
This is my first project.
I added some extra features:
• Delete existing links.
• Show a loader while waiting for the result.
• Receive an error message when the URL is invalid.
Feedbacks are very much welcome.
