css & html

Community feedback

• 

  MuhammadSamir•510

  @Muhammad-samirPosted over 2 years ago

  first of all It looks great on the mobile view but you have to change the width for your #mobile element to 260px instead of 70%; and it will work and you should fix your Html issues and everthing will be great.

  0

  ---

  

  sto•60

  @Sohila-SamirPosted over 2 years ago

  @Muhammad-samir thanks Mohamed I highly appreciate it. also I will consider your recommendation. however regarding the html issues. tbh I don't know where the issues is coming from as it mentions some lines of code that doesn't exist neither in my html file nor in the CSS. I don't know what is wrong!!!

  0
• 

  Prabhash Ranjan•2,540

  @besttlookkPosted over 2 years ago

  Hi, Nice work. Few things i like to mention:

  • When developing consider for all screen size. For in-between screen your design seems to break. Use developers-tools or resize the browser to see the differnce.

  Overall its looks okay. I completed this challenge yesterday only. Here is my solution:

  https://fem-chat-app.vercel.app/

  Good Luck.

  Happy Coding

  0

  ---

  

  sto•60

  @Sohila-SamirPosted over 2 years ago

  @besttlookk thanks for your feedback. I really appreciate it . and ik that the design will break on different screens that's because I didn't make it responsive for all screens as the design challenge was just for mobile (375px) and desktop (1440px).

  I'd consider making it responsive for all different screens tho later on.

  have a great day :)

  0