I used the front-mentor project as a base to be able to consume the tmdb api, I really liked this challenge, the api is very extensive, it has several resources, it still has many functionalities to be implemented, I also took this challenge to be able to study the new version more do next with client and server components, so if you want to give feedback or suggestion feel free
Renan Tiscoski
@DonUggioniAll comments
- @Samuel-AmaroSubmitted over 1 year ago@DonUggioniPosted over 1 year ago
Hey Samuel,
Great job on this one! I really liked the idea of fetching data from an API. I would try and improve and UI a little bit, it feels all too rough at the moment. Also, you could try to create a login and sign up form so users can create an account and save their favorite titles in a "to watch" list.
Happy coding 🤓
0 - @YAMANX8Submitted over 1 year ago
please look at my file structure and organisation, is it a good structure without using a framework?
@DonUggioniPosted over 1 year agoHey Yaman,
The folder structure looks good to me, only thing I would do is get rid of the unnecessary stuff like the design files and style guide for example.
Other than that, great job! It looks really good 👍
1 - @TjasaZilSubmitted over 1 year ago
Made with Vue3 and tailwind-
@DonUggioniPosted over 1 year agoHi there,
For some reason, the page is not responsive. On my laptop, I'm unable to click the button to generate the password as it's hidden outside the view port. Also, the bar has no color, it might be because I'm using firefox so maybe it needs some kind of webkit to work properly.
Marked as helpful0 - @KaeserOfHonourSubmitted over 1 year ago
Questions:
- When using SCSS modules for each component, should I name the module with "_name.module.scss" or underscore is not necessary?
- Is it a good idea to break the app into as many components as possible?
- If you have your own feedback ideas I would appreciate it.
Description:
I did this project with React and SASS, no other libraries were used( excluding linters ). I used localstorage to save URLs.
Thanks!
@DonUggioniPosted over 1 year agoHey there,
As far as I know, you don't need to use underscore to name a css module with React.
You can create as many components as you'd like, there is no set rule for that. One consideration you can have when creating components is if the project will grow and the same components will be used in many different places.
Happy coding 🤓
0 - @YanlDevSubmitted almost 2 years ago
Hello everyone 🤓💻, I'm Yaniv and this is my solution for the challenge #4
built with :
- Grid.
- Flex-box.
Help Me 😰:
I'm just starting and I broke my head trying to accommodate the backgrounds and I feel that my solution is very rudimentary, I hope someone can help me with that.
Thanks!💖
@DonUggioniPosted almost 2 years agoHey there,
To be honest, I think, your solution looks really good! You did a good job there, don't worry too much about it. Every project is a learning process and I'm sure that on your next project, some things will become easier and others will just be a new challenge and learning opportunity. Also, this is an incredibly simple project so, really don't worry about it too much =)
Keep it up and happy coding 🤓
Marked as helpful1 - @capitolcomputersSubmitted almost 2 years ago
I just completed this challenge and would love to get feedbacks and critics on how to improve further! Thanks.
@DonUggioniPosted almost 2 years agoHey Aijalon, great job on this one!
The code looks good and the JS and easy to read.
A couple of things I would have done differently are:
To center your
.main__container
, you could have set thebody
todisplay: flex, align-items: center, justify-content: center
This way, you make sure it's always centered in the screen.
Other thing is the button, you could have used the
:hover
pseudo-class instead of the:active
, or even better, you could have used both, for example: on:hover
you apply the current shadow and then on active, you can reduce the spread a bit to create a visual effect when you press the button.Other than that, pretty good job 👍 Keep it up!
Marked as helpful0 - @UpajiSubmitted almost 2 years ago
I do not know how to create the mobile and tablet version. I feel I have not learnt to do that yet. But maybe when I see other people's solution I will be able to learn from it.
@DonUggioniPosted almost 2 years agoHey there,
To make a page responsive, you need to use media queries. Search google or youtube for CSS Media queries and give it a go.
I'd advise you starting with something more simple, this project can get hard if you don't have much experience since there is a lot of different components.
0 - @DytomaSubmitted almost 2 years ago
Here is my solution for the clipboard landing page😇. I would encourage you to visit the site to look at this beautiful animations while scrolling.
Feel free to give your thoughts, feedback and maybe a rating😅.
@DonUggioniPosted almost 2 years agoHey there,
The animations look pretty nice! Great job . 👍
1 - @brspktsSubmitted almost 2 years ago
can u pls tell me what i was doing wrong ? i couldnt make the page responsive .
@DonUggioniPosted almost 2 years agoHey there,
I think your problem might be in your media query code:
@media (max-width:650){ #box-1, #box-2, #box-3{ width: 100%; height: auto; } }
You're not specifying the units on your max-width and I think it should be
@media and (max-width: 650px)
.Also, you could change flex box direction to column when it reaches that media query, to make it adapt to screen size.
0 - @wdbybSubmitted almost 2 years ago
Hi, y'all!
I think, adding SVGs and images as imports in app is not a great idea. How you solve this problem or what method you use to add static images/svgs?
Picture in App can be a component, the same with Text input with Checkbox in TodosList, but I thought about these as overkill, you?
Also have feeling that TodosList is too large?
As always probably miss something to ask more important that those questions but staying open to any advices and propositions.
Best regards!
@DonUggioniPosted almost 2 years agoHey there,
When dealing when SVG's, I like to tranform them into a sprite. A sprite is like a collection of svg's put into one single file. Look it up, it can be pretty handy. You can create these files online for free. Then in React, you do the following:
Import the file into the component -
import icons from '../../assets/images/icons-sprite.svg';
Then, to use a specific icon, you can do this:
<svg className="item__icon-check"> <use className="item__svg" xlinkHref={
${icons}#icon-check} /> </svg>
It works for me and I find it easier to deal with SVG's, change their fill colors, etc.
Hope it helps!
Marked as helpful1 - @valli450Submitted about 2 years ago
any criticism is welcome!)
@DonUggioniPosted about 2 years agoHey Val,
I think overall, it looks great! Good job!
The only thing I would point out is those arrows in the phone number field, they look a bit off. Have you considered removing them?
That's it, keep it up!
0 - @eyagargahSubmitted about 2 years ago
Hello everyone, this is my first advanced challenge on frontendMentor it was quite challenging and i struggled the most in css because i tried to recreate it as close to the design as possible so i would appreciate your feedback , remarks on how i can improve it any comment is appreciated and thank you for your time
@DonUggioniPosted about 2 years agoHey Eya,
Great job on finishing this project 👍 I noticed the score goes below zero, is that how it's supposed to be or should it be >= 0?
Also the background color when you hover the options look a little too strong visually, but that is just my personal taste.
Keep it up!
Happy coding 🤓
0