Advice generator app

Community feedback

• 

  Renan Tiscoski•1,240

  @DonUggioniPosted almost 2 years ago

  Hey Aijalon, great job on this one!

  The code looks good and the JS and easy to read.

  A couple of things I would have done differently are:

  To center your .main__container, you could have set the body to

  display: flex, align-items: center, justify-content: center

  This way, you make sure it's always centered in the screen.

  Other thing is the button, you could have used the :hover pseudo-class instead of the :active, or even better, you could have used both, for example: on :hover you apply the current shadow and then on active, you can reduce the spread a bit to create a visual effect when you press the button.

  Other than that, pretty good job 👍 Keep it up!

  Marked as helpful

  0

  ---

  

  Aijalon Bode•70

  @capitolcomputersPosted almost 2 years ago

  @DonUggioni Hey. Thanks man. I sure would add that display flex suggestions to my headers henceforth.

  Ohh great idea, didn't even think about doing that on hover. Thanks for suggesting!

  0