Skip to content
OverviewSolutions
30
Comments
59

Renan Tiscoski

@DonUggioniPortugal1,240 points

I’m a mysterious individual who has yet to fill out my bio. One thing’s for certain: I love writing front-end code!

Latest solutions

View more solutions

Latest comments

  • Renan Tiscoski•1,240
    @DonUggioniPosted almost 2 years ago

    Hey Samuel,

    Great job on this one! I really liked the idea of fetching data from an API. I would try and improve and UI a little bit, it feels all too rough at the moment. Also, you could try to create a login and sign up form so users can create an account and save their favorite titles in a "to watch" list.

    Happy coding 🤓

    0
  • Renan Tiscoski•1,240
    @DonUggioniPosted almost 2 years ago

    Hey Yaman,

    The folder structure looks good to me, only thing I would do is get rid of the unnecessary stuff like the design files and style guide for example.

    Other than that, great job! It looks really good 👍

    1
  • Renan Tiscoski•1,240
    @DonUggioniPosted about 2 years ago

    Hi there,

    For some reason, the page is not responsive. On my laptop, I'm unable to click the button to generate the password as it's hidden outside the view port. Also, the bar has no color, it might be because I'm using firefox so maybe it needs some kind of webkit to work properly.

    Marked as helpful
    0
  • Renan Tiscoski•1,240
    @DonUggioniPosted about 2 years ago

    Hey there,

    As far as I know, you don't need to use underscore to name a css module with React.

    You can create as many components as you'd like, there is no set rule for that. One consideration you can have when creating components is if the project will grow and the same components will be used in many different places.

    Happy coding 🤓

    0
  • Renan Tiscoski•1,240
    @DonUggioniPosted about 2 years ago

    Hey there,

    To be honest, I think, your solution looks really good! You did a good job there, don't worry too much about it. Every project is a learning process and I'm sure that on your next project, some things will become easier and others will just be a new challenge and learning opportunity. Also, this is an incredibly simple project so, really don't worry about it too much =)

    Keep it up and happy coding 🤓

    Marked as helpful
    1
  • Renan Tiscoski•1,240
    @DonUggioniPosted about 2 years ago

    Hey Aijalon, great job on this one!

    The code looks good and the JS and easy to read.

    A couple of things I would have done differently are:

    To center your .main__container, you could have set the body to

    display: flex, align-items: center, justify-content: center

    This way, you make sure it's always centered in the screen.

    Other thing is the button, you could have used the :hover pseudo-class instead of the :active, or even better, you could have used both, for example: on :hover you apply the current shadow and then on active, you can reduce the spread a bit to create a visual effect when you press the button.

    Other than that, pretty good job 👍 Keep it up!

    Marked as helpful
    0
View more comments