Manage Landing Page with React

Community feedback

• 

  Renan Tiscoski•1,240

  @DonUggioniPosted about 2 years ago

  Hey there,

  Congratulations on finishing this one, there is a couple of things I would point out;

  1- I would work a bit more on the responsiveness of the overall page, specially between the 1020px and 800px range.

  2- I would make the mobile navigation show up over the hero section, right now, when you open the mobile nav, it pushes everything down and I believe that's not something that is expected, you can easily fix that by setting it's position to absolute or fixed.

  Hope it helps!

  1

  ---

  

  aLpSabre•180

  @alpbracePosted about 2 years ago

  @DonUggioni Thank you so much for your comment. I still have to do stuff about responsiveness , you are right. But do you know how to put that background images responsively?

  0

  

  aLpSabre•180

  @alpbracePosted about 2 years ago

  @DonUggioni I have added overlay when mobile navigation opened up and it doesnt push the content anymore.Thank you for your suggestions.I will work on responsiveness.

  0

  

  Renan Tiscoski•1,240

  @DonUggioniPosted about 2 years ago

  @alpbrace Usually, since you're adding it through css, you could set it to cover or contain, see which one works better. Working with background images like that can be a pain sometimes.

  0