I did the bulk of this a month ago, and then got sidetracked. At the time all that was left to do was the spacing between sections, and inside the table. Also how to handle the header image using full width for mobile, and inside the card for desktop. (I think this was why I stopped at the time)
Latest solutions
Blog Preview Card with Fluid Sizing
PSubmitted 12 months agoNone, but any thoughts more than welcome.
Latest comments
- P@tarasisSubmitted 12 months agoWhat challenges did you encounter, and how did you overcome them?P@tarasisPosted 12 months ago
I'm aware of the H3 warning above. Will correct in due course.
0 - @DevK-EireSubmitted about 1 year agoP@tarasisPosted about 1 year ago
Great job, can't / won't comment on Tailwind / next.js build as I don't know enough.
Its nice and responsive, breaks nicely between the two sizes.
If you wanted me to be really (😹) pedantic there are two things in the "Preparation Time" callout:
First the wrap of "minutes" on mobile isn't in line with Total. However there is alignment further down the page on others that wrap.
Second, in the callout the
:
is outside the span, but further down you have the:
inside the span. To me both should be inside the span.Marked as helpful0 - @adamrichardturnerSubmitted about 1 year ago
Social Media Dashboard with Next.js, Tailwind, TypeScript and Shadcn
#next#tailwind-css#typescript#reactP@tarasisPosted about 1 year agoLooks great, and its responsive to resizing. Can't really comment on the code because I know nout about React/Tailwind so far.
Respondeds to tabbing which is good.
Only suggestion is breaking at 768px looks rough, you'd be better being two columns down closer towards the mobile size. Maybe 500? If I was looking on my iPad I'd feel it was a huge waste of screen real estate.
Marked as helpful0 - P@tarasisSubmitted about 1 year agoP@tarasisPosted about 1 year ago
Have SVG's for each of the social services but didn't end up adding them as an "enhancement"
0 - P@SphynxoSubmitted over 2 years agoP@tarasisPosted over 2 years ago
Hey congrats on finishing the challenge. There are some issues, particularly in the between sizes.
- Add
aria-label
s to the social links so that a screenreader will read out what the links are for. Particularly regarding the social links. - On tablet size (768x1024) the top right image is over the header text, and that continues to be the case until it swaps to the mobile version.
- Below about 560px to mobile version, the social icons go off the side of the page, causing horizontal scrolling. You would be better staying with mobile version till after that point.
- Between tablet and desktop sizing the red profile card goes behind the image.(in Safari). The problem here is that the
.offer-price-box
has a z-index of 0 after800px
. You setz-index: 3
in the media query uptomax-width: 50rem
. - Don't just support
:hover
, also add:focus
, you could do.ios-btn:where(:focus, :hover)
that way someone using the keyboard to navigate around the page gets the effect too. - Little thing, but there should be a
<br>
after the year in the footer. - Don't use empty
alt
s for images (on patterns, logos). Add a description, and it you feel its not an important thing for not sighted people, then usearia-hidden
on them. - You used the
apple
class for both the apple and android svgs.
Hope this was of some help to you.
Marked as helpful0 - Add
- @VictorDuranEMSubmitted over 2 years agoP@tarasisPosted over 2 years ago
Hey congrats on completing the challenge. Looks great, and nicely responds to screen being shrunk. (Can't comment on the code as I don't know tailwind)
Couple of little things:
- The social links at the bottom of the page should be
a
tags, which are selectable via the keyboard. Notli
tags. - The buttons and the social links should support
:focus
as well as:hover
- don't use
div
for everything. Try and use the approriate semantic tags where you can. For instance the bottom section should befooter
.
Marked as helpful0 - The social links at the bottom of the page should be