Latest comments

• 

  Pretty Kunene•690

  @nonozaSubmitted 11 months ago

  What are you most proud of, and what would you do differently next time?

  I'm happy because I finished a project after learning JavaScript from The Net Ninja. In the lesson, I learned how to use something called regex to check if the input in forms is correct.

  What challenges did you encounter, and how did you overcome them?

  I had a bit of challenge on an error section when the form moves when clicking the button and also aligning the list image icons.

  What specific areas of your project would you like help with?

  I would like some feedback on the challenges I mentioned and how to improve on my code.

  Thanks,

  

  Newsletter sign-up form with success message solution using Vanilla JS

  #accessibility#cube-css

  1

  40
  

  ortiz-antonio•270

  @ortiz-antonioPosted about 2 months ago

  Hi, I'm reviewing your project and noticed a few issues:

  • The dismiss button doesn't work

  • The CSS methodology isn't Cube CSS (your description states you're using it)

  • The form causes layout shifts when validation errors occur

  0
• 

  P

  Sven Notermans•160

  @Sven-27Submitted 3 months ago

  What are you most proud of, and what would you do differently next time?

  Had to find out again how to use Sass with regular html and how to compile it.

  And learned to store all of the imports into one folder so that is the only file that needs to be compiled. And the other files can be set as partials.

  What challenges did you encounter, and how did you overcome them?

  Took a little while to find how to compile sass to css. So i googled en read the docs on https://sass-lang.com/guide/

  What specific areas of your project would you like help with?

  All feedback is welcome

  

  Product Preview Card

  3

  50
  

  ortiz-antonio•270

  @ortiz-antonioPosted 3 months ago

  • In .display, you override the font-size with a px unit:

    font-size: $fs-32;
    font-size: 32px;
  

  • A CSS methodology like BEM could be beneficial.

  • The breakpoint for the desktop layout is too large, in my opinion. A flipped tablet could show the desktop layout in this design.

  0
• 

  Denislav•130

  @denislavdevSubmitted 3 months ago

  What are you most proud of, and what would you do differently next time?

  I'm really proud of the entire solution, especially how it all came together.

  What challenges did you encounter, and how did you overcome them?

  I ran into some challenges with the layout.

  What specific areas of your project would you like help with?

  I’d love feedback on improving best practices and making the project more accessible.

  

  Product Preview Card Component

  1

  10
  

  ortiz-antonio•270

  @ortiz-antonioPosted 3 months ago

  You forgot to use image-product-mobile.jpg.
  You can use the HTML <picture> tag or srcset to serve images based on size breakpoints.

  Marked as helpful

  1
• 

  Tracy Njoroge•70

  @26TracyNjorogeSubmitted 3 months ago

  

  Qr code component

  3

  30
  

  ortiz-antonio•270

  @ortiz-antonioPosted 3 months ago

  Looks good!
  Here are my two cents:

  • Variable naming convention: Usually, CSS variables have a suffix to indicate their purpose. For colors, I see most people use --colors-, although I’ve also seen --clrs-.

  • CSS naming convention: You can follow a CSS naming convention like BEM, OOCSS, SMACSS, or SUIT CSS.

  • Question about accessibility: How can a user with a visual disability, who needs to use zoom on mobile, read the content without needing to do horizontal scrolling?

  Marked as helpful

  1
• 

  P

  Jim Barnett•260

  @jamesbarnettSubmitted 8 months ago

  What are you most proud of, and what would you do differently next time?

  I was happy to get some more experience with flexbox. Also, not getting as married to my mark up and refactoring it when necessary. Next time I would use showModal.

  What challenges did you encounter, and how did you overcome them?

  I spent a lot of time making it resizable while the popup is active. Lots of debugging, tracing, and persistence.

  What specific areas of your project would you like help with?

  Anything that can be improved. Thanks for taking a look!

  

  Article Preview Card - Vanilla JS, Cube-CSS, Flex

  #cube-css#vite

  1

  30
  

  ortiz-antonio•270

  @ortiz-antonioPosted 3 months ago

  Great Job, I have an observation:

  • Where is the box shadow?
  • In small screens your layout breaks

  0
• 

  tushar-Ruhela•260

  @tushar-RuhelaSubmitted 7 months ago

  What are you most proud of, and what would you do differently next time?

  I am most proud of thing like create grid section more good looking and this make me most proud and next time i am making better design.

  What challenges did you encounter, and how did you overcome them?

  The challenges are encounter like add box size of grid and urgest these boxes according to giving design,and i overcome them by knowing about particluar topic which i have need and apply them .

  What specific areas of your project would you like help with?

  yes , some area i want share like font and grid design and any one want give feedback on them .

  

  testimonial-section using grid

  #cube-css

  2

  00
  

  ortiz-antonio•270

  @ortiz-antonioPosted 4 months ago

  Hi,

  When I finished my project, the system asked me to give you feedback. I'm learning too, so feel free to correct me if I say something wrong:

  • Self-hosted fonts load faster because they don’t require an extra HTTP request, and you can take advantage of caching.
  • Pixel-perfect design isn’t necessary anymore. I used to make the same mistake! Here’s a great article on the topic: @JoshWComeau’s article.
  • The recommended minimum font size is 16px. Below that, text becomes hard to read.
  • You can use CSS variables to avoid errors and improve the readability of your code.
  • The desktop version is clipped below 820px

  0