testimonial-section using grid

Community feedback

• 

  ortiz-antonio•250

  @ortiz-antonioPosted about 1 month ago

  Hi,

  When I finished my project, the system asked me to give you feedback. I'm learning too, so feel free to correct me if I say something wrong:

  • Self-hosted fonts load faster because they don’t require an extra HTTP request, and you can take advantage of caching.
  • Pixel-perfect design isn’t necessary anymore. I used to make the same mistake! Here’s a great article on the topic: @JoshWComeau’s article.
  • The recommended minimum font size is 16px. Below that, text becomes hard to read.
  • You can use CSS variables to avoid errors and improve the readability of your code.
  • The desktop version is clipped below 820px

  0
• 

  P

  newspaceracer•140

  @newspaceracerPosted about 1 month ago

  Hi, Looks good. I like how you solved the progressively more specific rules, I think you used ID which is not usually preferable but you made it work! Couple of suggestions:

  • I would start the design with the mobile first and then do the media query for the widescreen version as that gives you most flexibility and helps making sure the smaller screens work better. Right now the size of the cards is fixed to be on the smallest card size even when the screen is still wide but not wide enough to go to the grid view. So something to keep in mind.
  • test your responsiveness on the browser and adjust the media query based on when it starts to break
  • You repeated a bit of declaration on the cards even for items that were the same card after card. I would try to give attributes to a parent container where the cards are so that it cascades to the cards within. That way you don't have to repeat yourself as much.

  0