Frontend Mentor testimonials grid section: CUBE CSS, Eleventy

Community feedback

• 

  

  Grace•32,130

  @grace-snow

  Posted 5 months ago

  Oh no I just wrote loads of feedback then accidentally deleted it 😭 😆

  Oh well ill have to summarise quickly, there wasn't much:

  • you can't aria-labelledby an article by itself! That makes no sense and would lead to a bad experience for screen readers. If you really want to label these it should be pointing to the person's name.
  • the quote paragraphs should be in a blockquote element.
  • I'm not sure why you're adding tailwinds reset and then another reset.

  I can't really comment on css more than that as I'm only looking on mobile.

  Make sure you keep learning html even as you progress in the js learning path.

  11

  Marked as helpful