Michael Onyeaboβ’ 200
@michyking
Submitted
Eren
@erenymo
All comments
- Erenβ’ 720
@erenymo
Posted
Hi Thereπ
Congratulations to finish the project, it looks pretty good!π
BUTβ
Like most coders that I reviewed their solutions, you missed an important detail while doing this project. The leap year algorithm has critical role while calculating the age correctly.Basically, we care the leap year whether February will be 28 or 29 days in this project. Please check this website to have an idea how to calculate the leap year and please integrate it into your code.
Except this little but critical bug, you did a great job! Have fun and keep coding !π₯π
Marked as helpful
0 - Flavio Gomesβ’ 650
@flaviogp
Submitted
Hi there π, Iβm Flavio and this is my solution for this challenge. π
π οΈ Built With:
HTML5 CSS3 JavaScript
Any suggestions on how I can improve and reduce unnecessary code are welcome!
Thank you. πβοΈ
Erenβ’ 720@erenymo
Posted
Hi Thereπ
Congratulations for giving a chance to the project and trying your best.! π₯
Here are some my suggestions :
- You must consider about Error Handling. If there is some issue or something else, the user must be informed and guided. In this example, you can show an error message. For example, the month input can't be higher than 12. If user tries to input higher value than 12, than you can show 'invalid input' text message next to the input box.
- Also there is a logical error in calculating the age. As you know, February has maximum 29 days. You can take a look at this website to have an idea how to integrate leap year algorithm into your code to calculate the exact age.
- Finally, If you are a beginner, do not care much about writing PERFECT code. The most important thing that you should be focused is to make sure the code works correctly. Than you will be able to write clean code day by day ^^.
Except those, you did a great job πͺ! Have fun and keep codingπ₯π
0 - Rubenβ’ 250
@rugarcia25
Submitted
I have learned a lot about native CSS measurement units and it has also improved my logic in JavaScript.
I am very happy with the finished work.
If you could give me feedback, I would greatly appreciate it.
Erenβ’ 720@erenymo
Posted
Hi There π
Congratulations, good done !πͺ
Here is a little bug on your JS Logic :
- As you know, the day of February can be less or equal to 29 (leap year). To overcome this logical error, you can visit this website to have an idea about leap year algorithm.
Except this little bug, you did a great job! Have fun and keep coding ππ₯
Marked as helpful
1 - Patriciaβ’ 110
@Patixi
Submitted
Javascrip: I would like to simplify the 5 functions with an event ( "click") in just one if is posible. Could you help me with that?
Thanks a lot to everyone who spend time on reading me!!
Erenβ’ 720@erenymo
Posted
Hi Patriciaπ
To solve your problem, please look at event delegation concept.
Marked as helpful
0 - William Surya Pβ’ 20
@williamsuryap
Submitted
- confuse of chosing the color from the styling guide
- i still unsure how the best practice to write the code, i still on learning on how to have a clean code so the code are more less
- i still unsure how to include custom font on the webpage
Erenβ’ 720@erenymo
Posted
Hi Thereπ
Congratulations on your first step towards Frontend Mentor projects π₯³! By these projects, you will become more confident and practice your coding skills.πͺπ»
In order to clear your confuses:
- You will be familiar to choose right colors from the styling guide. Do not hesitate to make mistakes, just try it. If it doesn't fit, than change it, no big deal.π
- If you are beginner, do not focus on writing clean code. The most important point is to focus on the concept of the language at the beginning level. When you become more confident by building projects like this, than you can consider how to write clean code.
- You can check this video to learn about how to add custom font on webpage with html and css.
Great job dude, have fun and keep coding π
0 - Ana Carolinaβ’ 20
@anacarolinaks
Submitted
Is my code following best practices? Could you give me tips
Erenβ’ 720@erenymo
Posted
Hi π
Congrats to finish your first challenge on Frontend Mentor!
At the beginning of your roadmap, do not care how to write clean code while you just learning the fundamentals of the language.Give your attention to understanding the concepts. You should take care when you have confidence and hands-on experiences.
- Do not forget to fill the alt attribute of img tag. For example :
<img src="./images/image-qr-code.png" alt="QR Code image">This will increase the accesibility and SEO of your website.
Therefore, your code is also looks niceπ. Have fun and keep coding π
Marked as helpful
0 - Do not forget to fill the alt attribute of img tag. For example :
- Patriciaβ’ 110
@Patixi
Submitted
Do you see necesary to put the image and text into the divs, So i can put style directly to the div? Or is it better to do it with out it so the code is cleaner? thanks!
first challenge!!
Erenβ’ 720@erenymo
Posted
Hi Patriciaπ
First of all, welcome to the Frontend Mentor and congratulations to finish your first challengeπ₯³π! By these projects, you will practice your web development skills so much and gain hands-on experiences. πͺ
To answer your question:
-
No, it is not necessary to put the image and text into the divs everytime. Actually, it depends on the situation. If you . Sometimes divs can help you to style your components easily while working with flexbox or grid. If you know what you're doing, this won't cause much confusion for you. You will be confident when you build more projects.
-
What is more, please do some search about css units. At the beginning, there is no problem to use px unit while writing css to cover the fundamentals of the css BUT it will cause some responsive problems in the future.
You did a great job, have fun and keep codingπ₯π
Marked as helpful
0 -
- Jack Weru Kioniβ’ 240
@Jaweki
Submitted
Erenβ’ 720@erenymo
Posted
Hi thereπ
Overall, the solution looks good and fits on design but there is some lack of javascript :).
- One of aims of this project is practice your basic Javascript and DOM Manipulations. So, Mark all as read button should toggle the visual state of the unread notifications and set the number of unread messages to zero.
Before starting your project, reading Brief section of the project may give you more opportunities and get most out of the Frontend Mentor projects. These projects are valuable chance to practice and gain hands-on experiences.
Have fun and keep coding π₯π
Marked as helpful
0 - thomasraiterβ’ 60
@thomasraiter
Submitted
I'm having trouble centralizing, how can I avoid making mistakes again?
Erenβ’ 720@erenymo
Posted
Hi there π
Firstly, congratulations to give a chance to finish this project.
It is impossible not to make mistakes, we faces problems everytime and this is natural. Important point is think about how to solve issues during the coding process.
To solve and avoid making same mistakes again, here are some suggestions by me :
- Sometimes declaring manuel values (height: 1440px) to the containers or something else can cause problems in responsive web design. Please search on youtube how to improve your responsive skills. I suggest you to follow Kevin Powell on youtube. He has tons of videos like how to use the correct units for responsive design.
- While building the website, you can check easily how your website will look at any device. To check that, open chrome developer tools and use the toggle device toolbar a lot. This will make your coding process easier.
- Finally, please review other coders' solutions to the related project. This will provide you a different perspective.
I hope it will helpful for you.
Have fun and keep coding ππ
Marked as helpful
0 - iAmTheErrorβ’ 10
@iAmTheError
Submitted
My first challenge pls write feedback of what you think
Erenβ’ 720@erenymo
Posted
Hi thereπ
First of all, welcome to the Frontend Mentor Community !π₯
You will face many problems and bugs while building your projects and this will force you to solve problems and fix bugs. This is the most powerful way of how to learn coding along !
Lets start with some suggestions :
- First of all, you should know how to center a div exactly. You can check the video to how to center div in different ways : Click here !
- Secondly, the websites you create MUST also be compatible with mobile devices. You have to learn what is responsive design and improve it as much as you can.
You are at the beginning of the road and there is so much things to learn. Never give up and keep coding πππ
0 - Abdullahi Abdiaziz yusufβ’ 480
@Abdullahi-abdiaziz
Submitted
that`s age calculator app in js
Erenβ’ 720@erenymo
Posted
Hi coder π
Congratulations to finish another Frontend Mentor Project!
The design looks very nice.
Rather than design, I found some bugs in your JS Logic to calculate the age.
- As you know, the february can not be 30 days, its value can be maximum 29 ( if it is leap year) or less.
- Except the leap year, you may have some calculation errors. I tried October 20, 2023 and expected the result should be 2 days, but it showed me 6 days. You may need to revise your calculation algorithm.
To reach out more information about leap year algorithm, you can click here!
Have fun and keep coding ππππ
0 - PIslam Solimanβ’ 440
@simokitkat
Submitted
I would appreaciate any feedback on how i can improve my code.
Erenβ’ 720@erenymo
Posted
Hi there π
This is a very well solution, it really fits on design and hover effects are pleasing to the eyes. π
I really liked the project but here is a little bug on the logic.
- When I enter negative values in the Number of People section, the calculation shouldn't continue. Same issue happens in Bill section.
You can handle this little bug too.
In a nutshell, very well-done project, keep coding ππ
Marked as helpful
1
