Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Custom hooks and SCSS mixins

P
Islam Solimanβ€’ 440

@simokitkat

Desktop design screenshot for the Tip calculator app coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


I would appreaciate any feedback on how i can improve my code.

Community feedback

Erenβ€’ 720

@erenymo

Posted

Hi there πŸ‘‹

This is a very well solution, it really fits on design and hover effects are pleasing to the eyes. 😎

I really liked the project but here is a little bug on the logic.

  • When I enter negative values in the Number of People section, the calculation shouldn't continue. Same issue happens in Bill section.

You can handle this little bug too.

In a nutshell, very well-done project, keep coding πŸš€πŸš€

Marked as helpful

1

P
Islam Solimanβ€’ 440

@simokitkat

Posted

@erenymo Thank you for your feedback!

I have just fixed it now by adding the min attribute to the input fields.

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord