Skip to content
OverviewSolutions
27
Comments
19

Eren

@erenymoIstanbul, Turkey720 points

👨‍🎓🏫 Management Information Systems Student at Marmara University , 🚀 Software Developer Intern at Gelecek Varlık Yönetimi A.Ş.

I’m currently learning...

ASP.NET and React.JS

Latest solutions

View more solutions

Latest comments

  • Eren•720
    @erenymoPosted over 1 year ago

    Hi There👋

    Congratulations to finish the project, it looks pretty good!🎉

    BUT❗

    Like most coders that I reviewed their solutions, you missed an important detail while doing this project. The leap year algorithm has critical role while calculating the age correctly.Basically, we care the leap year whether February will be 28 or 29 days in this project. Please check this website to have an idea how to calculate the leap year and please integrate it into your code.

    Except this little but critical bug, you did a great job! Have fun and keep coding !🔥🚀

    Marked as helpful
    0
  • Eren•720
    @erenymoPosted over 1 year ago

    Hi There👋

    Congratulations for giving a chance to the project and trying your best.! 🔥

    Here are some my suggestions :

    • You must consider about Error Handling. If there is some issue or something else, the user must be informed and guided. In this example, you can show an error message. For example, the month input can't be higher than 12. If user tries to input higher value than 12, than you can show 'invalid input' text message next to the input box.
    • Also there is a logical error in calculating the age. As you know, February has maximum 29 days. You can take a look at this website to have an idea how to integrate leap year algorithm into your code to calculate the exact age.
    • Finally, If you are a beginner, do not care much about writing PERFECT code. The most important thing that you should be focused is to make sure the code works correctly. Than you will be able to write clean code day by day ^^.

    Except those, you did a great job 💪! Have fun and keep coding🔥🚀

    0
  • Eren•720
    @erenymoPosted over 1 year ago

    Hi There 👋

    Congratulations, good done !💪

    Here is a little bug on your JS Logic :

    • As you know, the day of February can be less or equal to 29 (leap year). To overcome this logical error, you can visit this website to have an idea about leap year algorithm.

    Except this little bug, you did a great job! Have fun and keep coding 🚀🔥

    Marked as helpful
    1
  • Eren•720
    @erenymoPosted over 1 year ago

    Hi Patricia👋

    To solve your problem, please look at event delegation concept.

    Marked as helpful
    0
  • Eren•720
    @erenymoPosted over 1 year ago

    Hi There👋

    Congratulations on your first step towards Frontend Mentor projects 🥳! By these projects, you will become more confident and practice your coding skills.💪🏻

    In order to clear your confuses:

    • You will be familiar to choose right colors from the styling guide. Do not hesitate to make mistakes, just try it. If it doesn't fit, than change it, no big deal.🙂
    • If you are beginner, do not focus on writing clean code. The most important point is to focus on the concept of the language at the beginning level. When you become more confident by building projects like this, than you can consider how to write clean code.
    • You can check this video to learn about how to add custom font on webpage with html and css.

    Great job dude, have fun and keep coding 🚀

    0
  • Eren•720
    @erenymoPosted over 1 year ago

    Hi 👋

    Congrats to finish your first challenge on Frontend Mentor!

    At the beginning of your roadmap, do not care how to write clean code while you just learning the fundamentals of the language.Give your attention to understanding the concepts. You should take care when you have confidence and hands-on experiences.

    • Do not forget to fill the alt attribute of img tag. For example : <img src="./images/image-qr-code.png" alt="QR Code image"> This will increase the accesibility and SEO of your website.

    Therefore, your code is also looks nice👏. Have fun and keep coding 🚀

    Marked as helpful
    0
View more comments