@erenymo
Posted
Hi There👋
Congratulations to finish the project, it looks pretty good!🎉
BUT❗
Like most coders that I reviewed their solutions, you missed an important detail while doing this project. The leap year algorithm has critical role while calculating the age correctly.Basically, we care the leap year whether February will be 28 or 29 days in this project. Please check this website to have an idea how to calculate the leap year and please integrate it into your code.
Except this little but critical bug, you did a great job! Have fun and keep coding !🔥🚀
Marked as helpful
@michyking
Posted
Thank you very much for your feedback. I really appreciate it and I will try to integrate your suggestion into my code @erenymo
@michyking
Posted
Hi @erenymo
I have implemented the suggestion you gave, can you check it out here?
@michyking
Posted
Hi @erenymo
I have implemented the suggestion you gave, can you check it out here?
@erenymo
Posted
Hi again, @michyking
I have checked your latest update, yes it is work partially but still there is an issue. When I input day : 30 or 31, month : 2 , it is still trying to calculate. I shouldn't be able to input higher value than 29 at the February.
A simple logic :
- If it is leap year, than value of the day input of February can be maximum 29 days, otherwise can be maximum 28 days.
I'm waiting for your latest implementation :).
@michyking
Posted
Hi @erenymo
It has been awhile. Thank you for this suggestion and I have done the needful.
