Mahdieh86• 20
@Mahdieh86
Submitted
clickglue
@clickglue
All comments
- clickglue• 120
@clickglue
Posted
Hi Mahdieh, I look your solution, it looks very similar to the challenge! In your code I see you used both a stylesheet and some direct styling on the P tag: this might be a bit complicated to maintain in a larger context. Also, I suggest you use the readme template to document your progress: it takes some time but is really helpful for yourself and others!
Marked as helpful
0 - Suleman Karigar• 30
@suleman1412
Submitted
clickglue• 120@clickglue
Posted
Hi Suleman, nice solution! I'm not an expert, but maybe you can consider using grid for the desktop layout, so image and text are always properly divided. Also, I'm not sure if you need two media queries. Would it be possible to develop for mobile, and then add a media query for desktop and only chnge the element that need correction?
0 - Nikola• 220
@porumbachanov
Submitted
What specific areas of your project would you like help with?
I tried to use the BEM methodology, would appreciate some feedback if I'm using it correctly.
clickglue• 120@clickglue
Posted
I've learned about the BEM methodology thanks to your approach and code. I think it is well implemented, even though there is just one Block (card). I don't know exactly if the 'overlay' is also compliant with the BEM method. Thank you!!
1 - imaginarygarden• 80
@imaginarygarden
Submitted
clickglue• 120@clickglue
Posted
Hi Imaginary Garden, beautiful solution! Very well organised CSS file, impressive, makes it easy to read. Two small questions: from earlier feedback I understood that it is better to load fonts in the HTML file, do you know what is better? And in the design files I saw that the mobile solution has no margin around the amge and no border radius. Your solution doesn't implement that.
Marked as helpful
0 - clickglue• 120
@clickglue
Submitted
What are you most proud of, and what would you do differently next time?
I'm happy to learn how to better analyze and prepare before I start coding. Also, CSS start to become more predictable if you structure it properly and do less trial-and-error.
What challenges did you encounter, and how did you overcome them?
Using flex is a challenge. Also, I'm not sure if I understand the concepts of 'responsive' correctly.
What specific areas of your project would you like help with?
How to implement responsive designs.
clickglue• 120@clickglue
Posted
Thank you Sherrisa (what a beautiful name), very interesting to see how you can approach the same challenge from very different angles!
0 - P
@shakthivel-rn
Submitted
What are you most proud of, and what would you do differently next time?
I learned about responsive design and how to transition differently for ease in and ease out
clickglue• 120@clickglue
Posted
Wauw this is beautiful! The ease in and out are great, very elegant. I was just wandering: you use px as dimension, I understood from another review that we should try to use rem instead: is that correct? I don't know, I don't have much experience.
0 - JxPV5• 30
@JxPV5
Submitted
What are you most proud of, and what would you do differently next time?
I'm quite proud of it, but I think I should write CSS more clearly next time.
What challenges did you encounter, and how did you overcome them?
None, I'm just mostly worried whether how I wrote most of the stuff was good practice.
What specific areas of your project would you like help with?
I just want to know what I should do differently, what stuff could've been done better.
clickglue• 120@clickglue
Posted
Hello, I think you've done an excellent job. I'm not an expert, but I can see your solution is well structured. Is it possible you forgot to implement the :hover for the main title? The challenge suggested that should change color on hover.
Marked as helpful
1
