Latest solutions
Results component, desktop and mobile versions with JSON data integrat
PSubmitted 6 months agoCSS selectors: too generic, too specific: are there better ways? And is it smart to first really master CSS before switching to SASS/LESS?
Latest comments
- @DandyHypeSubmitted 5 months ago
- @Johanh0Submitted about 1 year agoP@clickgluePosted 5 months ago
Hi Johan, what I like is that your code is clean, easy to read and well commented. So it is easy to follow. I think the overall result misses some details (slider, :hover, copied indication) compared to the figma file, but those are details. Good work, one or two iterations and it should be excellent!
0 - @fernandogadebarrosSubmitted 5 months agoP@clickgluePosted 5 months ago
Hi, great solution. There are some design differences but that is positive creativity I guess. I liked the fancy confirmation when copied! I see you used react, typescript and SCSS (even tailwind), and that is very interesting (I used just HTML, CSS and JS, three files only). I'm curious about your workflow and if you are happy with the speed of developing with these frameworks. I tried to find where you calculate the strength (because I thought that was an interesting part of the challenge) but I couldn't find it. Congratulations with the result!
0 - @DandyHypeSubmitted 5 months agoP@clickgluePosted 5 months ago
Hi, Great solution. The code looks clean and well organised. I can learn from your disciplined implementation of BEM. I tried to understand how you did the strength calculation, but didn't. But it works very well, congratualtions.
0 - @arsh-deSubmitted 5 months agoWhat are you most proud of, and what would you do differently next time?
I am proud that i was able to get the design and it looks dynamic according screen size of the device. I also changed the background color for input form as it was barely visible beforehand. I will try to improve my class names next and maybe use tailwind or bootstrap to finish the project. I will also practice more on JS as this time I was unable to get it right.
What challenges did you encounter, and how did you overcome them?I was unable to make JS work, I tried many times and failed every time, making my JS file a mess with different variable names that I didn't remember, and in the end I had to look at other people's solution to know what i was doing wrong. Next time I will do it on my own.
What specific areas of your project would you like help with?After this project, the part where I need to make the most effort is my JS skills and I will simply have to do more projects. Now I am going to challenge myself for making 1 project a day or even half of it at least. I am looking for some feedback, if someone can help me with variables naming and improve my design.
P@clickgluePosted 5 months agoHi, I think your solution is visually very good! There is a bit of an issue with the responsiveness around 768 px, but I think you can solve that. Functionally it doesn't work as it should. Your JS looks quite complicated, I suggest you take a look at other solutions of the same challenge and then try to simplify. If you've read the article on refactoring: there is a lot of value in writing DRY and simple JS, with just one task for each function! Good luck and keep on the good work!
Marked as helpful0 - @DandyHypeSubmitted 5 months agoP@clickgluePosted 5 months ago
Hi Dumitru, I liked your solution, great job! Some small issues with the functionality:
- It takes default two persons after reset, while the field displays '0'
- If I apply a custom amount, it takes 5%
Your JS code look quite organized, so I guess it will be easy to maintain and fix!
0