Newsletter subscrition

Community feedback

• 

  P

  thibault.deverge•310

  @thibault-devergePosted 2 months ago

  Hey, you've done some really great work here, well done!

  About the visual:

  • Some design elements are slightly different from the Figma file, like the border-radius being smaller and the background color not matching exactly. However, I actually prefer your version to the original design. Maybe that was intentional?
  • The responsiveness is broken between around 768px and 1000px. You might want to adjust the breakpoint to fix this, or avoid using a fixed width on the card in the desktop layout. Instead, you could use a percentage of the page width with a max-width, allowing the newsletter to adapt smoothly and grow with the screen up to a certain point.

  About the code:

  • I personally love the BEM naming convention for classes, and it's widely used professionally. It works especially well with SASS's nesting feature. It's a personal preference, but if you're unfamiliar with it, you might want to look into it and see if it suits you. :)
  • Consider using more variables for colors, font sizes, font weights, etc. For a small project, it’s not critical, but if you ever want to revisit the design, using variables will allow you to change things like the primary color across the project easily. It’s also useful if a client wants to make quick adjustments.
  • Also, not a big deal, but you could remove unnecessary files like the original README, template README, or HTML comments in index.html to keep things clean.

  As you can see, these are just small suggestions, as the code is really clear and the project is very well done. I hope some of this is useful. Wishing you the best with your next project! :)

  Marked as helpful

  0

  ---

  

  P

  clickglue•440

  @clickgluePosted 2 months ago

  Thank you, very usefull comments!@thibault-deverge

  1