:D
What challenges did you encounter, and how did you overcome them?No challenges
What specific areas of your project would you like help with?he text in the photos also changes its opacity. I don't know how to stop it from changing.
Do not hesitate over giving feedback about how I implemented the way the menu appears on mobile view.
Do not hesitate over giving feedback about how I implemented the way the menu appears on mobile view. I am wondering if there is a way to do that without JavaScript and in an accessible way.
Do not hesitate over giving feedback about accessibility if there are improvements in the way I implemented the validation errors and the toasted message.
No particular help requested.
Feel free to give me feedback about the class I coded to manage the Markdown-to-HTML conversion and about the tests I implemented.
:D
What challenges did you encounter, and how did you overcome them?No challenges
What specific areas of your project would you like help with?he text in the photos also changes its opacity. I don't know how to stop it from changing.
Some feedback:
.nav__links
(this would help you maintain your stylesheets in an easier way, avoiding useless repetitions);nav
element, while such a header should be within a header
element, the purpose of the nav
element being to structure a navigation menu (and only a navigation menu, even if such a menu is within a header);h1
element, while the “Immersive experiences that deliver” text should be treated like a paragraph;a
element instead of the button
one;p
element could be replaced by an a
element;img
element, not as a background image in CSS: even if these images are decorative, they can often be changed and using img
in such a context should make maintenance easier (in other words, think of the people who will manage the contents of the website and will want to add, update or delete some creations and their images: they should be able to do that without having to know how to deal with your stylesheets);opacity
, which applies not only to the background, but also to the contents and the children of the element concerned (see MDN): therefore, a better way is to use a background colour with an alpha channel or a background with a gradient if there is a gradient (you can have a look at my solution to have an idea of that);I hope this feedback helps you.
Some feedback:
I hope this feedback helps you.
It was my first Laravel project. I drastically modified the initial project, using the design and colors for the entire app. I'm very proud that I manage to host this app and make it work properly. It dinamically displays the shares and time of submission, it allows the users to edit their shares and profile pictures, sets permissions correctly, validates the webform input and displays errors. This app is connected to a real hosting, but it doesn't have an SSL certificate, which makes it show as unsafe. The link to the actual Laravel app: http://shares.ru.swtest.ru/
What challenges did you encounter, and how did you overcome them?A lot. I had to figure out how to use Laravel migrations, how to set up database on a hosting. I couldn't connect to my hosting by SSH despite entering the password correctly. After many hours of struggling, I came up with a solution to create an SSH key file and upload it directly to the hosting, which made it unneccessary to enter the password. After that, I coundn't install Composer on the server as PHP version was too old and I couldn't use the new one for some reason. After that, the migrations didn't work properly. I could go on and on, but after all, I overcame all these hardships and now my website works!
The solution does not seem to match the challenge or is concerning another challenge.
I cannot access both the repo and the preview site: I have a 404 status code.
Some feedback:
details
and summary
elements on MDN.I hope this feedback helps you.
Some feedback:
/
: they start from the website root and, as you host your challenge on GitHub Pages, where it is hosted in a directory, the images do not appear (start the relative paths with ./
to resolve the problem);height
property to set the height of blocks containing and instead use min-height
: if the contents are long enough, they can overflow when a fixed height is used for their container;grid-template-areas
, try to give the areas more semantic names (imagine testimonials change with different names);class
with semantics in mind (I am talking about the classes named following the names of the people leaving a testimonial).I hope this feedback helps you.