Design comparison
SolutionDesign
Community feedback
- @webdevbynightPosted 24 days ago
Some feedback:
- beware of relative paths starting with
/
: they start from the website root and, as you host your challenge on GitHub Pages, where it is hosted in a directory, the images do not appear (start the relative paths with./
to resolve the problem); - some elements from the design are missing: the “ in the purple card background and the box shadows for some cards;
- the grid container should have a maximum width for it does not stretch too much on very wide screens like a 27-inch one;
- you should avoid using the
height
property to set the height of blocks containing and instead usemin-height
: if the contents are long enough, they can overflow when a fixed height is used for their container; - when using
grid-template-areas
, try to give the areas more semantic names (imagine testimonials change with different names); - when naming a class, for the same reason as above, use
class
with semantics in mind (I am talking about the classes named following the names of the people leaving a testimonial).
I hope this feedback helps you.
1 - beware of relative paths starting with
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord