faq-accordion-with-scss

Community feedback

• 

  P

  webdevbynight•530

  @webdevbynightPosted 4 months ago

  Some feedback:

  • when clicking on the “minus” button, the expanded section does not close (is it intentional?);
  • when clicking on any “plus” button, the section previously opened gets closed, which may not be a best practice in terms of UX;
  • an user using the keyboard exclusively (such as a screen reader user) cannot access the answers at all, which means your solution has accessibility issues;
  • such an accordion can be done without JavaScript: check the details and summary elements on MDN.

  I hope this feedback helps you.

  Marked as helpful

  0

  ---

  

  Mohamed Ragheb•560

  @mohamed-fmPosted 4 months ago

  @webdevbynight Thank you for your feedback. The minus button was working, but there is a bug 🐛 in the new JS file that I just added, so I will fix this. And your feedback was very helpful. <3

  0