Skip to content
OverviewSolutions
14
Comments
13

Burak CLN

@brkclnTurkey385 points

I'm a developer who works for difficult projects who don't like easy projects. Especially puzzles and challenges. A developer who is always after the best practice.. Frontend Development

I’m currently learning...

React, Nextjs, Ecmascript..

Latest solutions

View more solutions

Latest comments

  • Burak CLN•385
    @brkclnPosted over 3 years ago

    Hey there, thanks for the sharing.. There are many ways for centering,

    • You may wanna look at this link. This might be what you're looking for.
    0
  • Burak CLN•385
    @brkclnPosted over 3 years ago

    Hey there, thanks for the sharing your work. Its pretty good. But i can say 2 3 thing about that.

    • its not centered, may wanna look at ..(You can use flexbox for that.)
    • setting fixed "height" and "with" not a good practice can overflow when text too much,
    • for padding and margin may wanna use "em" units, "rem" better for "font-size" good work keep up^^
    0
  • Burak CLN•385
    @brkclnPosted over 3 years ago

    Hello there, thanks for sharing your work. I can say 2 3 thing about your work..

    • Avoid to set "width and height" most of time you don't need,
    • Don't use "Pixel" for width, height its not a good practice and not responsive, use "em, vh or %" can search it. Padding and margin use "em" for sure..
    • Don't set width on body not a good practice,
    • For font-size you can use "rem" more responsive and new try to avoid "pixel",
    • And its not centered use of "height, left, right" etc.. Keep up ^^
    Marked as helpful
    1
  • Burak CLN•385
    @brkclnPosted over 3 years ago

    Hello there, thanks for sharing.. i can say 2 3 thing for your work.

    • Its looking like this on "chrome" https://prnt.sc/1qee9ew, and "opera" https://prnt.sc/1qee9xe lookin like this maybe wanna look at..
    • When i resize the screen its look like this https://prnt.sc/1qeea8c,
    • On tablet its overflowing https://prnt.sc/1qeeap5,
    • avoid to set "height" if u really wanna set height do it on "parent" like main.. keep up^^
    Marked as helpful
    1
  • Burak CLN•385
    @brkclnPosted over 3 years ago

    Hello there, Thanks for submitting your project. You did well, 3 - 4 thing i can say..

    • avoid to set "height" not a good practice (most of time),
    • I see unnecessary codes in the codes you wrote. Maybe you wanna look at,
    • For the font size try to use "rem" instead of "em" [watch this] (https://www.youtube.com/watch?v=pautqDqa54I)
    • Can add "main",
    • Can add "container" better experince, good work, keep up :)
    Marked as helpful
    1
  • Burak CLN•385
    @brkclnPosted over 3 years ago

    Hey there, Thanks for the posting your work.. For your 2.question

    • Have look at your "file path", probably problem here.. Look Here
    • I don't fully understand the problem. This can help; [shadow generator] (https://cssgenerator.org/box-shadow-css-generator.html)
    Marked as helpful
    0
View more comments