Skip to content
OverviewSolutions
25
Comments
100

Dušan Lukić

@dusanlukic404Serbia1,660 points

I’m a mysterious individual who has yet to fill out my bio. One thing’s for certain: I love writing front-end code!

Latest solutions

View more solutions

Latest comments

  • Dušan Lukić•1,660
    @dusanlukic404Posted almost 3 years ago

    Hi Karthik,

    Take a look on score part. Every game I won, I got -1 points which should not be correct.

    1
  • Dušan Lukić•1,660
    @dusanlukic404Posted almost 3 years ago

    Hi Samuel,

    Overall, you did great job congrats! You should have a look on your HTML and accessibility issues. There is a lot of issues so make sure to look at every and learn much more about them. Also, I saw that you used a default font-family so make sure to have a look in style-guide and to import proper font-families in your css, or link them in your HTML, button need more padding on top and bottom, and also line-height should not be 2 (too much). I think 1.6 would be perfect.

    *important: take a look on your markup and try to use semantic html, like h1, h2, h3 for headings, subheadings etc., button for buttons (not span with class of button), main etc.

    Marked as helpful
    0
  • Dušan Lukić•1,660
    @dusanlukic404Posted almost 3 years ago

    Try using smoother border-shadow on buttons and take a better look for footer color. They are not the same with the color from design. 😃

    0
  • Dušan Lukić•1,660
    @dusanlukic404Posted almost 3 years ago

    Hey Makson, great job! Well done 😊🙌 I suggest you to add load event on window element and delete value of inputs

    Marked as helpful
    0
  • Dušan Lukić•1,660
    @dusanlukic404Posted over 3 years ago

    Hey friend, take a look for your accessibility issues. There are a lot of them. Also, you should set smaller padding and in my opinion don't use fixed values (px) for your main container because on smaller screen's than yours it looks narrowly and there is no enough white space.

    Your solution does not meets the criteria of a given design. You should make also mobile version of this solution.

    Marked as helpful
    1
  • Dušan Lukić•1,660
    @dusanlukic404Posted over 3 years ago

    Hey Pranav, I just take a look on your solution. It looks very nice 😃

    I recommend you to do a few more things to make it better:

    • Add cursor pointer to your cards and also some transition on hovering over them
    • You have SO much accessibility and HTML issues so definitely you should take a deep look into it, change it and then generate new report
    • On mobile version border-radius looks weird

    Hope it helps!

    Marked as helpful
    1
View more comments