Skip to content
OverviewSolutions
25
Comments
100
Dušan Lukić
@dusanlukic404

All comments

  • Dušan Lukić•1,660
    @dusanlukic404Posted over 2 years ago

    Hi Karthik,

    Take a look on score part. Every game I won, I got -1 points which should not be correct.

    1
  • Dušan Lukić•1,660
    @dusanlukic404Posted over 2 years ago

    Hi Samuel,

    Overall, you did great job congrats! You should have a look on your HTML and accessibility issues. There is a lot of issues so make sure to look at every and learn much more about them. Also, I saw that you used a default font-family so make sure to have a look in style-guide and to import proper font-families in your css, or link them in your HTML, button need more padding on top and bottom, and also line-height should not be 2 (too much). I think 1.6 would be perfect.

    *important: take a look on your markup and try to use semantic html, like h1, h2, h3 for headings, subheadings etc., button for buttons (not span with class of button), main etc.

    Marked as helpful
    0
  • Dušan Lukić•1,660
    @dusanlukic404Posted over 2 years ago

    Try using smoother border-shadow on buttons and take a better look for footer color. They are not the same with the color from design. 😃

    0
  • Dušan Lukić•1,660
    @dusanlukic404Posted over 2 years ago

    Hey Makson, great job! Well done 😊🙌 I suggest you to add load event on window element and delete value of inputs

    Marked as helpful
    0
  • Dušan Lukić•1,660
    @dusanlukic404Posted almost 3 years ago

    Hey friend, take a look for your accessibility issues. There are a lot of them. Also, you should set smaller padding and in my opinion don't use fixed values (px) for your main container because on smaller screen's than yours it looks narrowly and there is no enough white space.

    Your solution does not meets the criteria of a given design. You should make also mobile version of this solution.

    Marked as helpful
    1
  • Dušan Lukić•1,660
    @dusanlukic404Posted almost 3 years ago

    Hey Pranav, I just take a look on your solution. It looks very nice 😃

    I recommend you to do a few more things to make it better:

    • Add cursor pointer to your cards and also some transition on hovering over them
    • You have SO much accessibility and HTML issues so definitely you should take a deep look into it, change it and then generate new report
    • On mobile version border-radius looks weird

    Hope it helps!

    Marked as helpful
    1
  • Aymen-Ben-Massoud•100
    @aymen-ben-massoudSubmitted almost 3 years ago

    image not showing in live server in github and vs code works why???

    first card

    1
    Dušan Lukić•1,660
    @dusanlukic404Posted almost 3 years ago

    Hey Aymen-Ben-Massoud, you need to set . before /images (so, ./images/url) to make your image visible. You type correct path but you need to set . before backslash.

    Also, check your accessibility issues and then generate new report when you're sure that you correct all of them.

    Hope it helps 😊

    Marked as helpful
    0
  • Dušan Lukić•1,660
    @dusanlukic404Posted almost 3 years ago

    Hey Jerry, very nice solution! Congrats 🎉

    I would only suggest you to always have some hover effect on interactive elements such as buttons. Also, then you should have some transition to make hovering nice and smooth.

    Keep having fun while coding! 😁

    Marked as helpful
    0
  • Syazwan Fitri•400
    @syzwnftrSubmitted about 3 years ago

    Hi, any feedback for improvement are greatly appreciated. I added a wiggle animation on this challenge and I would like to hear some thought about it. Plus, I fairly new to JavaScript and it would be really nice if someone can review my code.

    Intro Component With Sign Up Form | HTML, CSS Flexbox, JS

    2
    Dušan Lukić•1,660
    @dusanlukic404Posted about 3 years ago

    Awesome work Syazwan! I really like error messages. Do you have any advice where I can learn JS from scratch?

    0
  • Dušan Lukić•1,660
    @dusanlukic404Posted about 3 years ago

    Hi Mainul, very nice solution!

    I have a few suggestions for you:

    • You need to set box-shadow on your white boxes
    • Try to avoid horizontal and vertical scrollbar. For horizontal scrollbar you should delete min-width: 100vw; from body and for horizontal scrollbar you need to set margin: 2rem; instead of 5rem and also on body overflow: hidden;
    Marked as helpful
    1
  • Patryk Besler•355
    @beslerpatrykSubmitted over 3 years ago

    Hello everyone 👋 This is my "Sunnyside Agency Landing Page" solution using pure CSS and JS. If you see any issues with this project - let me know. Any criticism/comments can certainly help me learn and grow as a frontend developer. Thank you 😁

    Sunnyside Agency Landing Page | Pure CSS & JS

    1
    Dušan Lukić•1,660
    @dusanlukic404Posted about 3 years ago

    Hi Patryk, again 😆

    You did very nice job, here. I really like this mobile menu. Do you have any advice where I can learn JavaScript. It would be the next step in my learning process.

    Also, I have two suggestions for your solution:

    • You set max-width to body element and on desktop you have some white space on each side. Try to have some container with max-width and width and then add element in it
    • Making some animation on header arrow would be pretty nice. Try to do something with transform: translateY; to make it move vertically

    Keep coding, having fun and also learning! 😃

    0
  • Dušan Lukić•1,660
    @dusanlukic404Posted about 3 years ago

    Hi Hao, I don't have any suggestion for your solution. Awesome work man, congratulations!

    Marked as helpful
    1