Design comparison
Solution retrospective
Feedback greatly appreciated
Community feedback
- @dusanlukic404Posted over 2 years ago
Hi Samuel,
Overall, you did great job congrats! You should have a look on your HTML and accessibility issues. There is a lot of issues so make sure to look at every and learn much more about them. Also, I saw that you used a default font-family so make sure to have a look in style-guide and to import proper font-families in your css, or link them in your HTML, button need more padding on top and bottom, and also line-height should not be 2 (too much). I think 1.6 would be perfect.
*important: take a look on your markup and try to use semantic html, like h1, h2, h3 for headings, subheadings etc., button for buttons (not span with class of button), main etc.
Marked as helpful0@5erious5amPosted over 2 years ago@dusanlukic404 thanks a lot. Really informative. Will work on it.
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord