Skip to content
OverviewSolutions
14
Comments
807
Anosha Ahmed
@anoshaahmed

All comments

  • Victor•510
    @therealmaduanusiSubmitted almost 3 years ago

    Honestly it took me 5-6hrs to complete this but I finished it anyway😊

    HTML and CSS(flexbox)

    1
    Anosha Ahmed•9,300
    @anoshaahmedPosted almost 3 years ago

    5-6hrs is quick. good job!

    5
  • Jack Smith•10
    @jacksmith77Submitted almost 3 years ago

    Is there a better, more up to date way to write this code? For the HTML and CSS.

    HTML, CSS , Flexbox

    2
    Anosha Ahmed•9,300
    @anoshaahmedPosted almost 3 years ago

    Aim to use semantic tags when writing html. I would change div class="card" to main class="card". I'll also wrap the image in an h1. I see that you wrote two separate codes for the two screen sizes. Instead of that, I would recommend that you write the mobile code as your base code, then make a media query for the bigger size. For example, you can give a max-width to something, and then in the media query for the bigger size, you would just increase the max-width. That way you're building a responsive design but also doing less work

    you did great though. that's ^ just a way for u to upgrade ur behind-the-scene skills

    0
  • Anosha Ahmed•9,300
    @anoshaahmedPosted almost 3 years ago

    hey good job on this challenge! your report above shows a few issues though:

    • you should have at least one <h1> in your webpage

    • add alt="" to your <img> tags

    here is a list i made of accessibility issues & best practices

    hope this helps :))

    Marked as helpful
    0
  • Anosha Ahmed•9,300
    @anoshaahmedPosted almost 3 years ago

    hey good job on this challenge! you should have at least one <h1> in your webpage

    here is a list i made of accessibility issues & best practices

    hope this helps :))

    Marked as helpful
    1
  • Anosha Ahmed•9,300
    @anoshaahmedPosted almost 3 years ago

    hey good job on this challenge! your report above shows a few issues though:

    • wrap everything in your body in <main> OR use semantic tags! if you're using div right after body, then give them a role=""; however, it's a little frowned upon to use role right after body, so try to stick with semantic tags instead. you can read more about landmarks here

    • add alt="" to your <img> tags

    here is a list i made of accessibility issues & best practices

    hope this helps :))

    Marked as helpful
    1
  • Anosha Ahmed•9,300
    @anoshaahmedPosted almost 3 years ago

    hey good job on this challenge! wrap everything in your body in <main> OR use semantic tags! if you're using div right after body, then give them a role=""; however, it's a little frowned upon to use role right after body, so try to stick with semantic tags instead. you can read more about landmarks here

    here is a list i made of accessibility issues & best practices

    hope this helps :))

    Marked as helpful
    0
  • Anosha Ahmed•9,300
    @anoshaahmedPosted almost 3 years ago

    hey good job on this challenge! your report above shows a few issues though:

    • wrap everything in your body in <main> OR use semantic tags! if you're using div right after body, then give them a role=""; however, it's a little frowned upon to use role right after body, so try to stick with semantic tags instead. you can read more about landmarks here
    • start headings with <h1>, and move up by one level each time
    • add language to html like so: <html lang="en">

    here is a list i made of accessibility issues & best practices

    hope this helps :))

    Marked as helpful
    1
  • RTX3070•490
    @RTX3070Submitted almost 3 years ago

    Feedbacks are welcome! : )

    HTML5 CSS

    6
    Anosha Ahmed•9,300
    @anoshaahmedPosted almost 3 years ago

    hey good job on this challenge! your report above shows a few issues though:

    • wrap everything in your body in <main> OR use semantic tags! if you're using div right after body, then give them a role=""; however, it's a little frowned upon to use role right after body, so try to stick with semantic tags instead. you can read more about landmarks here

    • <section> and <article> usually need a heading; if you don't need a heading, use some other element such as <div>

    • use classes instead of id's, if you're going to use the same one more than once

    here is a list i made of accessibility issues & best practices

    hope this helps :))

    Marked as helpful
    1
  • Anosha Ahmed•9,300
    @anoshaahmedPosted almost 3 years ago

    hey good job on this challenge! your report above shows a few issues though:

    • wrap everything in your body in <main> OR use semantic tags! if you're using div right after body, then give them a role=""; however, it's a little frowned upon to use role right after body, so try to stick with semantic tags instead. you can read more about landmarks here
    • you should have at least one <h1> in your webpage

    here is a list i made of accessibility issues & best practices

    hope this helps :))

    Marked as helpful
    0
  • Anosha Ahmed•9,300
    @anoshaahmedPosted almost 3 years ago

    hey good job on this challenge! your report above shows a few issues though:

    • wrap everything in your body in <main> OR use semantic tags! if you're using div right after body, then give them a role=""; however, it's a little frowned upon to use role right after body, so try to stick with semantic tags instead. you can read more about landmarks here
    • you should have at least one <h1> in your webpage
    • <section> and <article> usually need a heading; if you don't need a heading, use some other element such as <div>

    here is a list i made of accessibility issues & best practices

    hope this helps :))

    0
  • Anosha Ahmed•9,300
    @anoshaahmedPosted almost 3 years ago

    hey good job on this challenge! your report above shows a few issues though:

    • wrap everything in your body in <main> OR use semantic tags! if you're using div right after body, then give them a role=""; however, it's a little frowned upon to use role right after body, so try to stick with semantic tags instead. you can read more about landmarks here
    • add alt="" to your <img> tags
    • if you're using an img as the h1, then the img must have an alt attribute

    here is a list i made of accessibility issues & best practices

    hope this helps :))

    0
  • Anosha Ahmed•9,300
    @anoshaahmedPosted almost 3 years ago

    hey good job on this challenge! your report above shows a few issues though:

    • wrap everything in your body in <main> OR use semantic tags! if you're using div right after body, then give them a role=""; however, it's a little frowned upon to use role right after body, so try to stick with semantic tags instead. you can read more about landmarks here

    • add alt="" to your <img> tags

    here is a list i made of accessibility issues & best practices

    hope this helps :))

    Marked as helpful
    0