Design comparison
SolutionDesign
Community feedback
- @anoshaahmedPosted almost 3 years ago
hey good job on this challenge! your report above shows a few issues though:
-
you should have at least one
<h1>
in your webpage -
add
alt=""
to your<img>
tags
here is a list i made of accessibility issues & best practices
hope this helps :))
Marked as helpful0 -
- @RioCantrePosted almost 3 years ago
Hello there! Awesome job with this one. Looking at your solution, I would suggest the following for you...
- Remove the
<section class="header">
in theheader
tag - Instead of using
nav
for thefooter-menu
andsocial-links
, utilized unordered or ordered list likeul
orol
and most common isdiv
orspan
- Place description to the
alt
in theimg
, don't leave it blank - Clean the Whitespaces and space in the code
- Add
cursor: pointer
for the hover state of the hamburger menu
Overall you did well and Keep it going!
0 - Remove the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord