CSS | HTML | Bem

Community feedback

• 

  Rio Cantre•9,690

  @RioCantrePosted almost 3 years ago

  Hello there! Awesome work with this challenge. Viewing your solution, you did well in implementing the code for the design and I would only suggest this for you...

  • Instead of using section wrap the whole content with main tag for semantic purpose and you need at least one heading to utilized the section tag.

  Overall you did well and Keep it up!

  1
• 

  Naveen Gumaste•10,480

  @NaveenGumastePosted almost 3 years ago

  Hay There ! Good Job on this challenge

  These below mentioned tricks will help you remove any Accessibility Issues

  -> Add Main tag after body like it should be your container

  -> For 1st heading or h1 tag, use header tag and then inside the header put your h1 or h2 etc

  -> But use header tag only once in main heading element.

  -> Always use h1 first and then h2, h3 and so on

  Keep up the good work!

  1
• 

  Anosha Ahmed•9,300

  @anoshaahmedPosted almost 3 years ago

  hey good job on this challenge! your report above shows a few issues though:

  • wrap everything in your body in <main> OR use semantic tags! if you're using div right after body, then give them a role=""; however, it's a little frowned upon to use role right after body, so try to stick with semantic tags instead. you can read more about landmarks here
  • you should have at least one <h1> in your webpage
  • <section> and <article> usually need a heading; if you don't need a heading, use some other element such as <div>

  here is a list i made of accessibility issues & best practices

  hope this helps :))

  0