order summary component using positioning

Community feedback

• 

  Rio Cantre•9,690

  @RioCantrePosted almost 3 years ago

  Hello there! Great job with this project. Looking at your solution, I think you should considered the following as well...

  • Add the hover state in the #proceedButton and add this background: hsla(245, 78%, 79%, 1);
  • Instead of wrapping the whole content with section which requires at least one heading, use main to wrap the page-center for readability
  • It's possible to wrap it with section tag the content in container-text
  • Add the attribution style in the CSS file and remove style tag
  • Emphasize the description of the alt and don't leave it blank

  Overall you did well and keep up the good work!

  Marked as helpful

  0

  ---

  

  s0h1s2•60

  @s0h1s2Posted almost 3 years ago

  @RioCantre thanks mate i appreciate your help

  1

  

  s0h1s2•60

  @s0h1s2Posted almost 3 years ago

  @RioCantre thanks mate i appreciate your help

  0
• 

  Anosha Ahmed•9,300

  @anoshaahmedPosted almost 3 years ago

  hey good job on this challenge! your report above shows a few issues though:

  • wrap everything in your body in <main> OR use semantic tags! if you're using div right after body, then give them a role=""; however, it's a little frowned upon to use role right after body, so try to stick with semantic tags instead. you can read more about landmarks here
  • you should have at least one <h1> in your webpage

  here is a list i made of accessibility issues & best practices

  hope this helps :))

  Marked as helpful

  0

  ---

  

  s0h1s2•60

  @s0h1s2Posted almost 3 years ago

  @anoshaahmed thanks madam i appreciate you helpful hint

  1

  

  s0h1s2•60

  @s0h1s2Posted almost 3 years ago

  @anoshaahmed thanks madam i appreciate you helpful hint

  0

  

  s0h1s2•60

  @s0h1s2Posted almost 3 years ago

  @anoshaahmed thanks madam i appreciate you helpful hint

  0

  

  s0h1s2•60

  @s0h1s2Posted almost 3 years ago

  @anoshaahmed thanks madam i appreciate you helpful hint

  0