- Any advice on how to use BEM more efficiently
- Please let me know if I made any mistakes in using semantic HTML tags
- Any Sass advice on how I can use it to make the code DRY (for eg - use of mixins)
Latest solutions
SASS Responsive Grid
#sass/scssPSubmitted 6 months agoFor this project I was aiming to get as close as possible to the design's font and topography, I would like to hear some feedback on how I did and if there is anything I can improve in my SCSS.
SCSS Responsive Design
#sass/scssPSubmitted 6 months agoI still cannot figure out why the gaps between my flex and the grid were completely messed up.
Tailwind Responsive Breakout Product Preview Card Component
#tailwind-cssPSubmitted 7 months agoCurrently the size of my project is the only thing I feel I can't get right even with the design right before me it always looks out of proportion and sizing images, text and so on to fit their place has been a struggle as well.
Tailwinds responsive sizing
#tailwind-cssPSubmitted 7 months agoUnderstanding better how to get and apply font's from the design files
Social Links - Dynamic Resizing
#tailwind-cssPSubmitted 8 months agoI would love to get some straight guidelines on how to size things, since the Figma Design says one thing and I hear all kinds of other suggestions.
How much should I trust Figma with the parameters it suggests?
Tailwind, Google fonts
#tailwind-cssPSubmitted 8 months agoA more simple way to center divs, maybe a better explanation on what containers, flexboxes ect are and in what cases to use them
Latest comments
- @py-code314Submitted 6 months agoWhat specific areas of your project would you like help with?P@ValsCodesPosted 6 months ago
Great job! Sematic HTML looks okay, might want to look more into it so you can feel more confident when using it. The layout is great, great touch with the 3 media queries. The mobile version at least in my opinion could use a max-width set to something lower. Very good separation of logic with the SASS. Even for a small project as this it very nice to see order in good shape. There aren't any considerable differences. Your purple testimonial's quote should have a different opacity and the box shadow seems a little bit more than needed. All minor stuff.
Keep going!
Marked as helpful0 - @RasMurph420Submitted 6 months agoWhat are you most proud of, and what would you do differently next time?
I'm proud of my ability to effectively use HTML and CSS to create a clean and responsive layout for the QR code component. The final product meets the design specifications and is visually appealing.
What challenges did you encounter, and how did you overcome them?Initially, I struggled with aligning the QR code image, title, and description to create a visually appealing layout. Ensuring everything was centered and looked good on different screen sizes was tricky.
The QR code image did not display properly on various devices, either being too large or too small, which affected the overall look of the component.
I initially encountered issues with linking my CSS file to the HTML document, which resulted in styles not being applied as expected.
P@ValsCodesPosted 6 months agoGreat solution! Congrats on your first submission!
I couldn't check the code on github. Just in case make sure to add alt to your image, use a sematic HTML tag and look into dynamic size units such as em and rem instead of px.
Keep at it!
Marked as helpful0 - P@hikawiSubmitted 6 months agoWhat challenges did you encounter, and how did you overcome them?
At first, because of the weird positioning of the background and the calculator, I was going to use absolute positioning on the calculator section. But it got too cumbersome and annoying to manage for each screen size, I ended up making the background absolute instead of the calculator, probably the better way.
The last section looked pretty intimidating. Using a grid with 12 columns may not be the optimal answer, but it worked out... well enough?
P@ValsCodesPosted 6 months agoVery impressive! Everything looks great!
Here are my suggestions for improvements:
- check the bool that changes the calculators welcome section. When you enter the site it shows the BMI text instead of the Welcome text
- the left blue part of the hero section in the design spans a little lower under the calculator
I think the 12 column grid looks awesome, don't touch it :) Size wise things are great and the code is readable.
Great job overall, keep going!
Marked as helpful0 - @cendyzSubmitted 6 months agoWhat are you most proud of, and what would you do differently next time?
My java skills improved, learned more about clamp and don't using height
P@ValsCodesPosted 6 months agoGreat job!
I barely have anything to say. Here is what I came up with:
- notice where the share button is in the design compared to the solution, a little margin on the right won't hurt
- try to stay away from using px as a unit especially when setting max height or width, there are some good extensions that convert px to em, rem and other units
- I couldn't see a sematic HTML tag used, adding role="main" to your main div is more than enough
Great job overall! Very impressive scss and solution, keep going!
Marked as helpful0 - @Jala30Submitted 6 months agoWhat are you most proud of, and what would you do differently next time?
Instead of just directly using htm, css and js. I tried writing thr code in typescript and scss and compiling them into Js and css using webpack. Doing so improved my knowledge in not only webpack but also in dynamic creation and querying of languages using typescript.
What challenges did you encounter, and how did you overcome them?I faced some issues due to the relative path of the image and mobile view.
What specific areas of your project would you like help with?Like I mentioned above, I faced some issues eth mobile view. So kindly provide suggestions and tips if any on not only mobile view but also overall. Also, is the way I applied mobile styles correct?
P@ValsCodesPosted 6 months agoGreat Job!
Here are some ideas for improvements:
- the mobile view can use more margin
- there is something weird happening with your bool that checks if a dropdown has been closed and opened, after you click it and close it, the header of the drop down stays with less opacity rather than going back to it's original state
- a little size up will get you closer to the design
- I could not see whether you have used sematic HTML tags such as <main></main> or just giving your main div this attribute role="main"
I am sorry if I didn't give you a better direction. Glad to hear that you learned a lot from this experiment. I am not sure if it is a common practice to write everything through code but since you had fun I guess everything is alright :)
Best regards, keep up the good work!
1 - @Provee510Submitted 6 months agoWhat are you most proud of, and what would you do differently next time?
Well just proud i did went harder than the last time, and probably would go even harder next time
What challenges did you encounter, and how did you overcome them?the toggle part was one of the hardest part for me because i am still new but somehow i did went pass it, follow by managing the useState, i know i need to improve more on this aspect just a very slow process for me.
What specific areas of your project would you like help with?managing useState and creating toggles to pop out a content
P@ValsCodesPosted 6 months agoGreat work! Very impressive work with the Javascript
Here are some ideas to look into
- the elephant in the room, the background color
- the mobile confirmation page can use some tweaking in terms of the margin/ padding
- a little size up on everything would get you closer to the design
- don't forget sematic HTML tags, add a simple role="main" to your outest divs
- take your time to get closer to the desired topography, it is supposed to have heavier font-weight at some places
Great work over all!
0