Article-preview-component

Community feedback

• 

  P

  Ivaylo Ivanov•260

  @ValsCodesPosted about 2 months ago

  Great job!

  I barely have anything to say. Here is what I came up with:

  • notice where the share button is in the design compared to the solution, a little margin on the right won't hurt
  • try to stay away from using px as a unit especially when setting max height or width, there are some good extensions that convert px to em, rem and other units
  • I couldn't see a sematic HTML tag used, adding role="main" to your main div is more than enough

  Great job overall! Very impressive scss and solution, keep going!

  Marked as helpful

  0

  ---

  

  cendyz•450

  @cendyzPosted about 2 months ago

  @ValsCodes Thank you!

  1. I thinked about margin right in this part but finally I don't added it
  2. Next time I can use em instead of px, no thinked too much about it
  3. When I creating "card" like this project, I don't think about main/header/section etc. tags but if it will be better with "main" tag then ok

  🫡

  0